* cmd_struct
@ 2015-05-13 23:10 Thiago Farina
2015-05-13 23:23 ` cmd_struct Jonathan Nieder
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thiago Farina @ 2015-05-13 23:10 UTC (permalink / raw)
To: Git Mailing List
Hi,
Would be too churn/noise (at this point) to rename cmd_struct to builtin_cmd?
I know "Why" question could come, but I prefer to not answer it if I can.
Regards,
--
Thiago Farina
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: cmd_struct
2015-05-13 23:10 cmd_struct Thiago Farina
@ 2015-05-13 23:23 ` Jonathan Nieder
2015-05-13 23:24 ` cmd_struct Junio C Hamano
2015-05-14 7:49 ` cmd_struct Johannes Schindelin
2 siblings, 0 replies; 5+ messages in thread
From: Jonathan Nieder @ 2015-05-13 23:23 UTC (permalink / raw)
To: Thiago Farina; +Cc: Git Mailing List
Hi,
Thiago Farina wrote:
> Would be too churn/noise (at this point) to rename cmd_struct to builtin_cmd?
>
> I know "Why" question could come, but I prefer to not answer it if I can.
The answer depends on the "why". (Not "why do you ask?", but "why
rename --- what benefit would it bring?")
Thanks and hope that helps,
Jonathan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: cmd_struct
2015-05-13 23:10 cmd_struct Thiago Farina
2015-05-13 23:23 ` cmd_struct Jonathan Nieder
@ 2015-05-13 23:24 ` Junio C Hamano
2015-05-13 23:31 ` cmd_struct Junio C Hamano
2015-05-14 7:49 ` cmd_struct Johannes Schindelin
2 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2015-05-13 23:24 UTC (permalink / raw)
To: Thiago Farina; +Cc: Git Mailing List
On Wed, May 13, 2015 at 4:10 PM, Thiago Farina <tfransosi@gmail.com> wrote:
>
> Would be too churn/noise (at this point) to rename cmd_struct to builtin_cmd?
The name has served us well, I do not see a compelling reason to change it
to anything else, and I suspect the name stayed unchanged because nobody
else found such a reason, either.
So... if you are unwilling to make a compelling case telling us why the current
name does not work, I do not think it is likely that anybody finds such a change
necessary, welcome, or even tolerable.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: cmd_struct
2015-05-13 23:24 ` cmd_struct Junio C Hamano
@ 2015-05-13 23:31 ` Junio C Hamano
0 siblings, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2015-05-13 23:31 UTC (permalink / raw)
To: Thiago Farina; +Cc: Git Mailing List
Junio C Hamano <gitster@pobox.com> writes:
> On Wed, May 13, 2015 at 4:10 PM, Thiago Farina <tfransosi@gmail.com> wrote:
>>
>> Would be too churn/noise (at this point) to rename cmd_struct to builtin_cmd?
>
> The name has served us well, I do not see a compelling reason to change it
> to anything else, and I suspect the name stayed unchanged because nobody
> else found such a reason, either.
>
> So... if you are unwilling to make a compelling case telling us why the current
> name does not work, I do not think it is likely that anybody finds such a change
> necessary, welcome, or even tolerable.
Having said that, I would agree that if I were writing git.c from
scratch today, I would have done
static struct builtin_cmd builtin_cmd[] = { ...
insead of the current
static struct cmd_struct commands[] = { ...
just because I think it makes more sense. But that reason suggests
it is a mere code churn of no value, after all these years.
"Because the non-POSIX non-ANSI-C platform I am porting for stomps
on the end-user program's namespace, and cmd_struct is one of the
victims" could be a reason that is better than "just because I think
it makes more sense", but even then, there would probably be a
better ways other than renaming the symbols in end-user code
(i.e. Git) to solve such a name clash.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: cmd_struct
2015-05-13 23:10 cmd_struct Thiago Farina
2015-05-13 23:23 ` cmd_struct Jonathan Nieder
2015-05-13 23:24 ` cmd_struct Junio C Hamano
@ 2015-05-14 7:49 ` Johannes Schindelin
2 siblings, 0 replies; 5+ messages in thread
From: Johannes Schindelin @ 2015-05-14 7:49 UTC (permalink / raw)
To: Thiago Farina; +Cc: Git Mailing List
Hi Thiago,
On 2015-05-14 01:10, Thiago Farina wrote:
> Would be too churn/noise (at this point) to rename cmd_struct to builtin_cmd?
>
> I know "Why" question could come, but I prefer to not answer it if I can.
It would be too much churn/noise, but I prefer not to describe why, if I can.
*grins*
Ciao,
Dscho
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-14 7:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-13 23:10 cmd_struct Thiago Farina
2015-05-13 23:23 ` cmd_struct Jonathan Nieder
2015-05-13 23:24 ` cmd_struct Junio C Hamano
2015-05-13 23:31 ` cmd_struct Junio C Hamano
2015-05-14 7:49 ` cmd_struct Johannes Schindelin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.