All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Avishay Matayev <me@avishay.dev>
Cc: git@vger.kernel.org, code@tpope.net
Subject: Re: [PATCH 2/3] Allow isatty to be overriden with GIT_FORCE_TTY
Date: Fri, 09 Jul 2021 11:41:36 -0700	[thread overview]
Message-ID: <xmqqfswn72jj.fsf@gitster.g> (raw)
In-Reply-To: <CAJ-0Osx4A0NaY9f5Z-6_H2rfW-XwyDmW_7+OxKFt7WJaWOixSQ@mail.gmail.com> (Avishay Matayev's message of "Fri, 9 Jul 2021 20:24:15 +0300")

Avishay Matayev <me@avishay.dev> writes:

>> > If you don't find the approach in this patch good enough, what exactly
>> > do you suggest?
>>
>> Start with not tying this feature with the word "TTY", probably.
> Well then, what are other indicators of 'interactivity' besides "TTY"?

If we want to force output to always go through the pager, we should
call it "force pager", not "force tty".  If we want to always show
progress bar no matter where the output goes, we should call it
"force progress", not "force tty".  These should be controllable
independenty, even though it is OK to have catch all "force
everything" for convenience.

There is no inherent reason why the output has to be passed through
the pager when it goes to tty.  It merely is how we happen to have
designed the heuristics.  We don't want to carve it in stone and
expose it on end-users with a poorly chosen name.  Also, we do not
want to tie multiple features unnecessarily.

  reply	other threads:[~2021-07-09 18:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 21:03 [PATCH 0/3] Override isatty with GIT_FORCE_TTY Avishay Matayev
2021-07-06 21:03 ` [PATCH 1/3] Change isatty's parameter to a *_FILENO define Avishay Matayev
2021-07-06 21:59   ` Junio C Hamano
2021-07-09 14:41     ` Avishay Matayev
2021-07-06 21:03 ` [PATCH 2/3] Allow isatty to be overriden with GIT_FORCE_TTY Avishay Matayev
2021-07-06 22:03   ` Junio C Hamano
2021-07-09 14:49     ` Avishay Matayev
2021-07-09 17:21       ` Junio C Hamano
2021-07-09 17:24         ` Avishay Matayev
2021-07-09 18:41           ` Junio C Hamano [this message]
2021-07-09 19:56             ` Avishay Matayev
2021-07-06 21:03 ` [PATCH 3/3] Add tests for GIT_FORCE_TTY Avishay Matayev
2021-07-30 12:04 ` [PATCH 0/3] Override isatty with GIT_FORCE_TTY Avishay Matayev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfswn72jj.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=code@tpope.net \
    --cc=git@vger.kernel.org \
    --cc=me@avishay.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.