All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: Is GGG mislabeling topics?
Date: Thu, 02 Feb 2023 09:06:08 -0800	[thread overview]
Message-ID: <xmqqk010uhdr.fsf@gitster.g> (raw)
In-Reply-To: <52c9ed08-43c3-80c6-32f6-42209b799af6@gmx.de> (Johannes Schindelin's message of "Thu, 2 Feb 2023 15:20:24 +0100 (CET)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> On Thu, 19 Jan 2023, Junio C Hamano wrote:
>
>> These comments from GGG bot
>>
>>     https://github.com/git/git/pull/1435#issuecomment-1386301994
>>     https://github.com/git/git/pull/1435#issuecomment-1386302018
>>
>> add 'next' and 'seen' labels, citing merges e3ead5f and c52b021
>> respectively, but these merges are of a topic that has little to do
>> with this pull request (#1435).  Is this expected?
>
> Since I could not make `amlog` work reliably for GitGitGadget ...

"git rev-list e3ead5f^..e3ead5f" (as the comment claims that GGG saw
e3ead5f merged this topic) should be able to identify the individual
commits merged, in this case three topmost commits from Peff leading
to 6c065f72 (http: support CURLOPT_PROTOCOLS_STR, 2023-01-16).

> What you see in action is that this is imperfect. Because in the absence
> of actual git/git commits that correspond to the GitGitGadget Pull
> Requests' commits, `range-diff` will even identify replacements or
> alternative patches as the git/git commits corresponding to the PR.

Hmph, so the three topmost commits were mistaken to match the
patch(es) on this branch.  That's sort-of understandable but not
very satisfactory.

And amlog seems to know the message ID that resulted in that topmost
commit that was merged to 'next'.

    $ git notes --ref notes/amlog show e3ead5f^2
    Message-Id: <Y8YQUD8bMHc4Lmph@coredump.intra.peff.net>

Perhaps GGG can be told to recognise that it is not one of the
messages it sent out before, or something?


      reply	other threads:[~2023-02-02 17:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 17:32 Is GGG mislabeling topics? Junio C Hamano
2023-02-02 14:20 ` Johannes Schindelin
2023-02-02 17:06   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk010uhdr.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.