* [PATCH] fetch doc: src side of refspec could be full SHA-1
@ 2017-10-17 3:56 Junio C Hamano
2017-10-17 19:35 ` Jonathan Nieder
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2017-10-17 3:56 UTC (permalink / raw)
To: git
Since a9d34933 ("Merge branch 'fm/fetch-raw-sha1'", 2015-06-01) we
allow to fetch by an object name when the other side accepts such a
request, but we never updated the documentation to match.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
Documentation/pull-fetch-param.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/pull-fetch-param.txt b/Documentation/pull-fetch-param.txt
index 1ebbf1d738..733f932479 100644
--- a/Documentation/pull-fetch-param.txt
+++ b/Documentation/pull-fetch-param.txt
@@ -23,9 +23,11 @@ ifdef::git-pull[]
endif::git-pull[]
+
The format of a <refspec> parameter is an optional plus
-`+`, followed by the source ref <src>, followed
+`+`, followed by the source <src>, followed
by a colon `:`, followed by the destination ref <dst>.
-The colon can be omitted when <dst> is empty.
+The colon can be omitted when <dst> is empty. <src> is most
+typically a ref, but it can also be an fully spelled hex object
+name.
+
`tag <tag>` means the same as `refs/tags/<tag>:refs/tags/<tag>`;
it requests fetching everything up to the given tag.
--
2.15.0-rc1-168-g2b9456ab46
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fetch doc: src side of refspec could be full SHA-1
2017-10-17 3:56 [PATCH] fetch doc: src side of refspec could be full SHA-1 Junio C Hamano
@ 2017-10-17 19:35 ` Jonathan Nieder
2017-10-17 21:00 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Nieder @ 2017-10-17 19:35 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Jonathan Tan
Hi Junio,
Junio C Hamano wrote:
> Since a9d34933 ("Merge branch 'fm/fetch-raw-sha1'", 2015-06-01) we
> allow to fetch by an object name when the other side accepts such a
> request, but we never updated the documentation to match.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> Documentation/pull-fetch-param.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Good catch.
> --- a/Documentation/pull-fetch-param.txt
> +++ b/Documentation/pull-fetch-param.txt
> @@ -23,9 +23,11 @@ ifdef::git-pull[]
> endif::git-pull[]
> +
> The format of a <refspec> parameter is an optional plus
> -`+`, followed by the source ref <src>, followed
> +`+`, followed by the source <src>, followed
> by a colon `:`, followed by the destination ref <dst>.
> -The colon can be omitted when <dst> is empty.
> +The colon can be omitted when <dst> is empty. <src> is most
> +typically a ref, but it can also be an fully spelled hex object
> +name.
nits:
s/most typically/typically/
s/an fully/a fully/
With those tweaks,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fetch doc: src side of refspec could be full SHA-1
2017-10-17 19:35 ` Jonathan Nieder
@ 2017-10-17 21:00 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2017-10-17 21:00 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: git, Jonathan Tan
Jonathan Nieder <jrnieder@gmail.com> writes:
> nits:
>
> s/most typically/typically/
> s/an fully/a fully/
>
> With those tweaks,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-17 21:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-17 3:56 [PATCH] fetch doc: src side of refspec could be full SHA-1 Junio C Hamano
2017-10-17 19:35 ` Jonathan Nieder
2017-10-17 21:00 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.