Re: [PATCH v5 2/5] setup: sanity check file size in read_gitfile_gently

From: Junio C Hamano <gitster@pobox.com>
To: "Erik Elfström" <erik.elfstrom@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v5 2/5] setup: sanity check file size in read_gitfile_gently
Date: Wed, 29 Apr 2015 08:42:22 -0700	[thread overview]
Message-ID: <xmqqy4lb54bl.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1430030985-14499-3-git-send-email-erik.elfstrom@gmail.com> ("Erik =?utf-8?Q?Elfstr=C3=B6m=22's?= message of "Sun, 26 Apr 2015 08:49:42 +0200")

Erik Elfström <erik.elfstrom@gmail.com> writes:

> diff --git a/setup.c b/setup.c
> index c4538ca..792c37b 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -364,6 +364,10 @@ const char *read_gitfile_gently(const char *path, int *return_error_code)
>  		error_code = READ_GITFILE_ERR_OPEN_FAILED;
>  		goto cleanup_return;
>  	}
> +	if (st.st_size > PATH_MAX * 4) {
> +		error_code = READ_GITFILE_ERR_TOO_LARGE;

You have fd already open for the path at this point.  When you
reroll, please do not forget to close(fd) here.

> +		goto cleanup_return;
> +	}