All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Ser <contact@emersion.fr>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Pekka Paalanen <ppaalanen@gmail.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	linux-media@vger.kernel.org, xorg-devel@lists.x.org,
	dri-devel@lists.freedesktop.org,
	wayland-devel@lists.freedesktop.org
Subject: Re: Call for an EDID parsing library
Date: Thu, 08 Apr 2021 15:34:10 +0000	[thread overview]
Message-ID: <xpo_2Bu6zqaJzYEya05hXM6WtcyBfk7EHevrdAN_AeWWdpMqGjIUBQ5ZqBMhpGWjhG1ASfvXzHAJhE2cKF4bRkq7xBdbzHk7UyPeaK_amRY=@emersion.fr> (raw)
In-Reply-To: <87lf9siyn6.fsf@intel.com>

On Thursday, April 8th, 2021 at 5:28 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:

> On Thu, 08 Apr 2021, Simon Ser contact@emersion.fr wrote:
>
> > On Thursday, April 8th, 2021 at 4:58 PM, Jani Nikula jani.nikula@linux.intel.com wrote:
> >
> > > Perhaps that should be the takeaway; try to minimize parsed data
> > > where the consumer needs to know whether it originated from DisplayID or
> > > EDID?
> >
> > So an EDID/DisplayID abstraction layer?
> >
> > It sounds like only an EDID and DisplayID expert could come up with a
> > sane API for that. Also some metadata will only be available in one
> > format and not the other.
>
> Well, some of the data already comes from DisplayID extensions in the
> EDID.
>
> My point is, if you parse displayid and edid into different structures
> and APIs, what will the code bases using the library end up looking
> like? Not pretty? Implementing the same conditionals all over the place?
> Anyway. I feel like I'm derailing this a bit, and I really don't want
> that to happen. I think DisplayID is a consideration that should not be
> forgotten, but it's probably not the first priority here.

I agree with the goal. I'm just saying that it considerably increases
the complexity of the task.

If you're just doing an EDID library, you can just expose the EDID
specific bits with a sane API. If you're designing an abstraction
layer, you need to have a good look at both APIs, try to come up with
common data structures that fit both, and be aware of the upcoming spec
changes to not be stuck with a bad API.

WARNING: multiple messages have this Message-ID (diff)
From: Simon Ser <contact@emersion.fr>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: xorg-devel@lists.x.org, dri-devel@lists.freedesktop.org,
	wayland-devel@lists.freedesktop.org,
	Hans Verkuil <hverkuil@xs4all.nl>,
	linux-media@vger.kernel.org
Subject: Re: Call for an EDID parsing library
Date: Thu, 08 Apr 2021 15:34:10 +0000	[thread overview]
Message-ID: <xpo_2Bu6zqaJzYEya05hXM6WtcyBfk7EHevrdAN_AeWWdpMqGjIUBQ5ZqBMhpGWjhG1ASfvXzHAJhE2cKF4bRkq7xBdbzHk7UyPeaK_amRY=@emersion.fr> (raw)
In-Reply-To: <87lf9siyn6.fsf@intel.com>

On Thursday, April 8th, 2021 at 5:28 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:

> On Thu, 08 Apr 2021, Simon Ser contact@emersion.fr wrote:
>
> > On Thursday, April 8th, 2021 at 4:58 PM, Jani Nikula jani.nikula@linux.intel.com wrote:
> >
> > > Perhaps that should be the takeaway; try to minimize parsed data
> > > where the consumer needs to know whether it originated from DisplayID or
> > > EDID?
> >
> > So an EDID/DisplayID abstraction layer?
> >
> > It sounds like only an EDID and DisplayID expert could come up with a
> > sane API for that. Also some metadata will only be available in one
> > format and not the other.
>
> Well, some of the data already comes from DisplayID extensions in the
> EDID.
>
> My point is, if you parse displayid and edid into different structures
> and APIs, what will the code bases using the library end up looking
> like? Not pretty? Implementing the same conditionals all over the place?
> Anyway. I feel like I'm derailing this a bit, and I really don't want
> that to happen. I think DisplayID is a consideration that should not be
> forgotten, but it's probably not the first priority here.

I agree with the goal. I'm just saying that it considerably increases
the complexity of the task.

If you're just doing an EDID library, you can just expose the EDID
specific bits with a sane API. If you're designing an abstraction
layer, you need to have a good look at both APIs, try to come up with
common data structures that fit both, and be aware of the upcoming spec
changes to not be stuck with a bad API.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-04-08 15:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07  8:44 Call for an EDID parsing library Pekka Paalanen
2021-04-07  8:44 ` Pekka Paalanen
2021-04-07  8:55 ` Carsten Haitzler
2021-04-07  8:55   ` Carsten Haitzler
2021-04-07  9:34 ` Hans Verkuil
2021-04-07  9:34   ` Hans Verkuil
2021-04-07 10:31   ` Jani Nikula
2021-04-07 10:31     ` Jani Nikula
2021-04-07 11:00     ` Hans Verkuil
2021-04-07 11:00       ` Hans Verkuil
2021-04-08 13:49       ` Jani Nikula
2021-04-08 13:49         ` Jani Nikula
2021-04-08 14:13         ` Pekka Paalanen
2021-04-08 14:13           ` Pekka Paalanen
2021-04-08 14:58           ` Jani Nikula
2021-04-08 14:58             ` Jani Nikula
2021-04-08 15:10             ` Simon Ser
2021-04-08 15:10               ` Simon Ser
2021-04-08 15:28               ` Jani Nikula
2021-04-08 15:28                 ` Jani Nikula
2021-04-08 15:34                 ` Simon Ser [this message]
2021-04-08 15:34                   ` Simon Ser
2021-04-07 10:59 ` Simon Ser
2021-04-07 10:59   ` Simon Ser
2021-04-07 12:40   ` Jonas Ådahl
2021-04-07 12:40     ` Jonas Ådahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='xpo_2Bu6zqaJzYEya05hXM6WtcyBfk7EHevrdAN_AeWWdpMqGjIUBQ5ZqBMhpGWjhG1ASfvXzHAJhE2cKF4bRkq7xBdbzHk7UyPeaK_amRY=@emersion.fr' \
    --to=contact@emersion.fr \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hverkuil@xs4all.nl \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=ppaalanen@gmail.com \
    --cc=wayland-devel@lists.freedesktop.org \
    --cc=xorg-devel@lists.x.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.