* [PATCH] qla2xxx: Log PCI address in qla_nvme_unregister_remote_port()
@ 2021-05-31 12:24 Daniel Wagner
2021-06-01 15:46 ` Himanshu Madhani
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Daniel Wagner @ 2021-05-31 12:24 UTC (permalink / raw)
To: linux-scsi
Cc: linux-kernel, GR-QLogic-Storage-Upstream, Nilesh Javali, Daniel Wagner
Pass in fcport->vha to ql_log() in order to add the PCI address to the
log.
Currently NULL is passed in which gives this confusing log entry:
> qla2xxx [0000:00:00.0]-2112: : qla_nvme_unregister_remote_port: unregister remoteport on 0000000009d6a2e9 50000973981648c7
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index 0cacb667a88b..e119f8b24e33 100644
--- a/drivers/scsi/qla2xxx/qla_nvme.c
+++ b/drivers/scsi/qla2xxx/qla_nvme.c
@@ -671,7 +671,7 @@ void qla_nvme_unregister_remote_port(struct fc_port *fcport)
if (!IS_ENABLED(CONFIG_NVME_FC))
return;
- ql_log(ql_log_warn, NULL, 0x2112,
+ ql_log(ql_log_warn, fcport->vha, 0x2112,
"%s: unregister remoteport on %p %8phN\n",
__func__, fcport, fcport->port_name);
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] qla2xxx: Log PCI address in qla_nvme_unregister_remote_port()
2021-05-31 12:24 [PATCH] qla2xxx: Log PCI address in qla_nvme_unregister_remote_port() Daniel Wagner
@ 2021-06-01 15:46 ` Himanshu Madhani
2021-06-02 3:14 ` Martin K. Petersen
2021-06-08 3:05 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Himanshu Madhani @ 2021-06-01 15:46 UTC (permalink / raw)
To: Daniel Wagner, linux-scsi
Cc: linux-kernel, GR-QLogic-Storage-Upstream, Nilesh Javali
On 5/31/21 7:24 AM, Daniel Wagner wrote:
> Pass in fcport->vha to ql_log() in order to add the PCI address to the
> log.
>
> Currently NULL is passed in which gives this confusing log entry:
>
>> qla2xxx [0000:00:00.0]-2112: : qla_nvme_unregister_remote_port: unregister remoteport on 0000000009d6a2e9 50000973981648c7
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
> index 0cacb667a88b..e119f8b24e33 100644
> --- a/drivers/scsi/qla2xxx/qla_nvme.c
> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
> @@ -671,7 +671,7 @@ void qla_nvme_unregister_remote_port(struct fc_port *fcport)
> if (!IS_ENABLED(CONFIG_NVME_FC))
> return;
>
> - ql_log(ql_log_warn, NULL, 0x2112,
> + ql_log(ql_log_warn, fcport->vha, 0x2112,
> "%s: unregister remoteport on %p %8phN\n",
> __func__, fcport, fcport->port_name);
>
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qla2xxx: Log PCI address in qla_nvme_unregister_remote_port()
2021-05-31 12:24 [PATCH] qla2xxx: Log PCI address in qla_nvme_unregister_remote_port() Daniel Wagner
2021-06-01 15:46 ` Himanshu Madhani
@ 2021-06-02 3:14 ` Martin K. Petersen
2021-06-08 3:05 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-06-02 3:14 UTC (permalink / raw)
To: Daniel Wagner
Cc: linux-scsi, linux-kernel, GR-QLogic-Storage-Upstream, Nilesh Javali
Daniel,
> Pass in fcport->vha to ql_log() in order to add the PCI address to the
> log.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qla2xxx: Log PCI address in qla_nvme_unregister_remote_port()
2021-05-31 12:24 [PATCH] qla2xxx: Log PCI address in qla_nvme_unregister_remote_port() Daniel Wagner
2021-06-01 15:46 ` Himanshu Madhani
2021-06-02 3:14 ` Martin K. Petersen
@ 2021-06-08 3:05 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-06-08 3:05 UTC (permalink / raw)
To: Daniel Wagner, linux-scsi
Cc: Martin K . Petersen, GR-QLogic-Storage-Upstream, Nilesh Javali,
linux-kernel
On Mon, 31 May 2021 14:24:44 +0200, Daniel Wagner wrote:
> Pass in fcport->vha to ql_log() in order to add the PCI address to the
> log.
>
> Currently NULL is passed in which gives this confusing log entry:
>
> > qla2xxx [0000:00:00.0]-2112: : qla_nvme_unregister_remote_port: unregister remoteport on 0000000009d6a2e9 50000973981648c7
Applied to 5.14/scsi-queue, thanks!
[1/1] qla2xxx: Log PCI address in qla_nvme_unregister_remote_port()
https://git.kernel.org/mkp/scsi/c/27c707b14659
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-08 3:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-31 12:24 [PATCH] qla2xxx: Log PCI address in qla_nvme_unregister_remote_port() Daniel Wagner
2021-06-01 15:46 ` Himanshu Madhani
2021-06-02 3:14 ` Martin K. Petersen
2021-06-08 3:05 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.