* [PATCH] SCSI: bnx2fc: fix Kconfig warning & CNIC build errors
@ 2021-02-13 19:24 Randy Dunlap
2021-02-23 3:26 ` Martin K. Petersen
2021-02-26 2:22 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-02-13 19:24 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Saurav Kashyap, Javed Hasan,
GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi
CNIC depends on MMU, but since 'select' does not follow any
dependency chains, SCSI_BNX2X_FCOE also needs to depend on MMU,
so that erroneous configs are not generated, which cause build
errors in cnic.
WARNING: unmet direct dependencies detected for CNIC
Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && PCI [=y] && (IPV6 [=n] || IPV6 [=n]=n) && MMU [=n]
Selected by [y]:
- SCSI_BNX2X_FCOE [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && PCI [=y] && (IPV6 [=n] || IPV6 [=n]=n) && LIBFC [=y] && LIBFCOE [=y]
riscv64-linux-ld: drivers/net/ethernet/broadcom/cnic.o: in function `.L154':
cnic.c:(.text+0x1094): undefined reference to `uio_event_notify'
riscv64-linux-ld: cnic.c:(.text+0x10bc): undefined reference to `uio_event_notify'
riscv64-linux-ld: drivers/net/ethernet/broadcom/cnic.o: in function `.L1442':
cnic.c:(.text+0x96a8): undefined reference to `__uio_register_device'
riscv64-linux-ld: drivers/net/ethernet/broadcom/cnic.o: in function `.L0 ':
cnic.c:(.text.unlikely+0x68): undefined reference to `uio_unregister_device'
Fixes: 853e2bd2103a ("[SCSI] bnx2fc: Broadcom FCoE offload driver")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Saurav Kashyap <skashyap@marvell.com>
Cc: Javed Hasan <jhasan@marvell.com>
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
---
drivers/scsi/bnx2fc/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20210212.orig/drivers/scsi/bnx2fc/Kconfig
+++ linux-next-20210212/drivers/scsi/bnx2fc/Kconfig
@@ -5,6 +5,7 @@ config SCSI_BNX2X_FCOE
depends on (IPV6 || IPV6=n)
depends on LIBFC
depends on LIBFCOE
+ depends on MMU
select NETDEVICES
select ETHERNET
select NET_VENDOR_BROADCOM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SCSI: bnx2fc: fix Kconfig warning & CNIC build errors
2021-02-13 19:24 [PATCH] SCSI: bnx2fc: fix Kconfig warning & CNIC build errors Randy Dunlap
@ 2021-02-23 3:26 ` Martin K. Petersen
2021-02-26 2:22 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-02-23 3:26 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, Saurav Kashyap, Javed Hasan,
GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi
Randy,
> CNIC depends on MMU, but since 'select' does not follow any dependency
> chains, SCSI_BNX2X_FCOE also needs to depend on MMU, so that erroneous
> configs are not generated, which cause build errors in cnic.
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SCSI: bnx2fc: fix Kconfig warning & CNIC build errors
2021-02-13 19:24 [PATCH] SCSI: bnx2fc: fix Kconfig warning & CNIC build errors Randy Dunlap
2021-02-23 3:26 ` Martin K. Petersen
@ 2021-02-26 2:22 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-02-26 2:22 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Martin K . Petersen, James E.J. Bottomley, linux-scsi,
Saurav Kashyap, GR-QLogic-Storage-Upstream, kernel test robot,
Javed Hasan
On Sat, 13 Feb 2021 11:24:28 -0800, Randy Dunlap wrote:
> CNIC depends on MMU, but since 'select' does not follow any
> dependency chains, SCSI_BNX2X_FCOE also needs to depend on MMU,
> so that erroneous configs are not generated, which cause build
> errors in cnic.
>
> WARNING: unmet direct dependencies detected for CNIC
> Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && PCI [=y] && (IPV6 [=n] || IPV6 [=n]=n) && MMU [=n]
> Selected by [y]:
> - SCSI_BNX2X_FCOE [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && PCI [=y] && (IPV6 [=n] || IPV6 [=n]=n) && LIBFC [=y] && LIBFCOE [=y]
>
> [...]
Applied to 5.12/scsi-queue, thanks!
[1/1] SCSI: bnx2fc: fix Kconfig warning & CNIC build errors
https://git.kernel.org/mkp/scsi/c/eefb816acb01
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-26 2:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-13 19:24 [PATCH] SCSI: bnx2fc: fix Kconfig warning & CNIC build errors Randy Dunlap
2021-02-23 3:26 ` Martin K. Petersen
2021-02-26 2:22 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.