* [PATCH] scsi: gdth: make option_setup() static
@ 2020-09-15 8:40 Jason Yan
2020-09-16 1:35 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-09-15 8:40 UTC (permalink / raw)
To: achim_leubner, jejb, martin.petersen, linux-scsi; +Cc: Jason Yan, Hulk Robot
This addresses the following sparse warning:
drivers/scsi/gdth.c:3229:12: warning: symbol 'option_setup' was not
declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/gdth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index dc0e17729acf..0519d3fa43d4 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -3226,7 +3226,7 @@ static void __init internal_setup(char *str,int *ints)
}
}
-int __init option_setup(char *str)
+static int __init option_setup(char *str)
{
int ints[MAXHA];
char *cur = str;
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: gdth: make option_setup() static
2020-09-15 8:40 [PATCH] scsi: gdth: make option_setup() static Jason Yan
@ 2020-09-16 1:35 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-09-16 1:35 UTC (permalink / raw)
To: Jason Yan; +Cc: achim_leubner, jejb, martin.petersen, linux-scsi, Hulk Robot
Jason,
> This addresses the following sparse warning:
>
> drivers/scsi/gdth.c:3229:12: warning: symbol 'option_setup' was not
> declared. Should it be static?
drivers/scsi/gdth.c:3229:19: error: ‘option_setup’ defined but not used [-Werror=unused-function]
3229 | static int __init option_setup(char *str)
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-16 1:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 8:40 [PATCH] scsi: gdth: make option_setup() static Jason Yan
2020-09-16 1:35 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.