* [PATCH v2] scsi: ufs: enable link lost interrupt
[not found] <CGME20220802014552epcas2p236519c03464ab32d9a877887710b1c10@epcas2p2.samsung.com>
@ 2022-08-02 1:42 ` Kiwoong Kim
2022-08-02 17:27 ` Bart Van Assche
2022-08-12 2:08 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Kiwoong Kim @ 2022-08-02 1:42 UTC (permalink / raw)
To: linux-scsi, linux-kernel, alim.akhtar, avri.altman, jejb,
martin.petersen, beanhuo, adrian.hunter, sc.suh, hy50.seo,
sh425.lee, bhoon95.kim
Cc: Kiwoong Kim
v1 -> v2: add a fixes tag
Link lost is treated as fatal error with the patch
c99b9b2, but its event isn't registered as interrupt source,
so I enable it.
Fixes: c99b9b2 ("scsi: ufs: Treat link loss as fatal error")
Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
---
drivers/scsi/ufs/ufshci.h | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
index a7ff0e5..0b627f4 100644
--- a/drivers/scsi/ufs/ufshci.h
+++ b/drivers/scsi/ufs/ufshci.h
@@ -133,11 +133,7 @@ static inline u32 ufshci_version(u32 major, u32 minor)
#define UFSHCD_UIC_MASK (UIC_COMMAND_COMPL | UFSHCD_UIC_PWR_MASK)
-#define UFSHCD_ERROR_MASK (UIC_ERROR |\
- DEVICE_FATAL_ERROR |\
- CONTROLLER_FATAL_ERROR |\
- SYSTEM_BUS_FATAL_ERROR |\
- CRYPTO_ENGINE_FATAL_ERROR)
+#define UFSHCD_ERROR_MASK (UIC_ERROR | INT_FATAL_ERRORS)
#define INT_FATAL_ERRORS (DEVICE_FATAL_ERROR |\
CONTROLLER_FATAL_ERROR |\
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] scsi: ufs: enable link lost interrupt
2022-08-02 1:42 ` [PATCH v2] scsi: ufs: enable link lost interrupt Kiwoong Kim
@ 2022-08-02 17:27 ` Bart Van Assche
2022-08-12 2:08 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2022-08-02 17:27 UTC (permalink / raw)
To: Kiwoong Kim, linux-scsi, linux-kernel, alim.akhtar, avri.altman,
jejb, martin.petersen, beanhuo, adrian.hunter, sc.suh, hy50.seo,
sh425.lee, bhoon95.kim
On 8/1/22 18:42, Kiwoong Kim wrote:
> Link lost is treated as fatal error with the patch
> c99b9b2, but its event isn't registered as interrupt source,
> so I enable it.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] scsi: ufs: enable link lost interrupt
2022-08-02 1:42 ` [PATCH v2] scsi: ufs: enable link lost interrupt Kiwoong Kim
2022-08-02 17:27 ` Bart Van Assche
@ 2022-08-12 2:08 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-08-12 2:08 UTC (permalink / raw)
To: Kiwoong Kim
Cc: linux-scsi, linux-kernel, alim.akhtar, avri.altman, jejb,
martin.petersen, beanhuo, adrian.hunter, sc.suh, hy50.seo,
sh425.lee, bhoon95.kim
Kiwoong,
> v1 -> v2: add a fixes tag
Version commentary needs to go after the patch description separated by
a triple dash.
> Link lost is treated as fatal error with the patch c99b9b2
Commit hashes need to be 12 characters long.
I fixed these up and applied to 5.20/scsi-staging.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-12 2:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20220802014552epcas2p236519c03464ab32d9a877887710b1c10@epcas2p2.samsung.com>
2022-08-02 1:42 ` [PATCH v2] scsi: ufs: enable link lost interrupt Kiwoong Kim
2022-08-02 17:27 ` Bart Van Assche
2022-08-12 2:08 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.