From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: lduncan@suse.com, cleech@redhat.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, open-iscsi@googlegroups.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled
Date: Mon, 19 Mar 2018 23:26:25 -0400 [thread overview]
Message-ID: <yq1a7v31l7i.fsf@oracle.com> (raw)
In-Reply-To: <1520425743-1923-1-git-send-email-jianchao.w.wang@oracle.com> (Jianchao Wang's message of "Wed, 7 Mar 2018 20:29:03 +0800")
Jianchao,
> iscsi tcp will first send out data, then calculate and send data
> digest. If we don't have BDI_CAP_STABLE_WRITES, the page cache will
> be written in spite of the on going writeback. Consequently, wrong
> digest will be got and sent to target.
>
> To fix this, set BDI_CAP_STABLE_WRITES when data digest is enabled
> in iscsi_tcp .slave_configure callback.
Applied to 4.16/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Jianchao Wang <jianchao.w.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: lduncan-IBi9RG/b67k@public.gmane.org,
cleech-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
jejb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled
Date: Mon, 19 Mar 2018 23:26:25 -0400 [thread overview]
Message-ID: <yq1a7v31l7i.fsf@oracle.com> (raw)
In-Reply-To: <1520425743-1923-1-git-send-email-jianchao.w.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> (Jianchao Wang's message of "Wed, 7 Mar 2018 20:29:03 +0800")
Jianchao,
> iscsi tcp will first send out data, then calculate and send data
> digest. If we don't have BDI_CAP_STABLE_WRITES, the page cache will
> be written in spite of the on going writeback. Consequently, wrong
> digest will be got and sent to target.
>
> To fix this, set BDI_CAP_STABLE_WRITES when data digest is enabled
> in iscsi_tcp .slave_configure callback.
Applied to 4.16/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2018-03-20 3:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 12:29 [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled Jianchao Wang
2018-03-14 7:00 ` jianchao.wang
2018-03-14 7:00 ` jianchao.wang
2018-03-15 4:11 ` Martin K. Petersen
2018-03-15 4:11 ` Martin K. Petersen
2018-03-15 10:37 ` Lee Duncan
2018-03-15 10:37 ` Lee Duncan
2018-03-15 18:05 ` Chris Leech
2018-03-15 18:05 ` Chris Leech
2018-03-20 3:26 ` Martin K. Petersen [this message]
2018-03-20 3:26 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1a7v31l7i.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=cleech@redhat.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jianchao.w.wang@oracle.com \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.