[PATCH] scsi: ufs: ufshcd-pltfrm: simplify usages of pdev->dev

[PATCH] scsi: ufs: ufshcd-pltfrm: simplify usages of pdev->dev

[Krzysztof Kozlowski]

The 'struct device' pointer is already cached as local variable in
ufshcd_pltfrm_init(), so use it.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/scsi/ufs/ufshcd-pltfrm.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 87975d1a21c8..cca4b2181a81 100644
--- a/drivers/scsi/ufs/ufshcd-pltfrm.c
+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
@@ -341,7 +341,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
 
 	err = ufshcd_alloc_host(dev, &hba);
 	if (err) {
-		dev_err(&pdev->dev, "Allocation failed\n");
+		dev_err(dev, "Allocation failed\n");
 		goto out;
 	}
 
@@ -349,13 +349,13 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
 
 	err = ufshcd_parse_clock_info(hba);
 	if (err) {
-		dev_err(&pdev->dev, "%s: clock parse failed %d\n",
+		dev_err(dev, "%s: clock parse failed %d\n",
 				__func__, err);
 		goto dealloc_host;
 	}
 	err = ufshcd_parse_regulator_info(hba);
 	if (err) {
-		dev_err(&pdev->dev, "%s: regulator init failed %d\n",
+		dev_err(dev, "%s: regulator init failed %d\n",
 				__func__, err);
 		goto dealloc_host;
 	}
@@ -368,8 +368,8 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
 		goto dealloc_host;
 	}
 
-	pm_runtime_set_active(&pdev->dev);
-	pm_runtime_enable(&pdev->dev);
+	pm_runtime_set_active(dev);
+	pm_runtime_enable(dev);
 
 	return 0;
 
-- 
2.32.0

RE: [PATCH] scsi: ufs: ufshcd-pltfrm: simplify usages of pdev->dev

[Chanho Park]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, April 1, 2022 5:51 PM
> To: Alim Akhtar <alim.akhtar@samsung.com>; Avri Altman
> <avri.altman@wdc.com>; James E.J. Bottomley <jejb@linux.ibm.com>; Martin
K.
> Petersen <martin.petersen@oracle.com>; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH] scsi: ufs: ufshcd-pltfrm: simplify usages of pdev->dev
> 
> The 'struct device' pointer is already cached as local variable in
> ufshcd_pltfrm_init(), so use it.

Reviewed-by: Chanho Park <chanho61.park@samsung.com>

Best Regards,
Chanho Park

> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/scsi/ufs/ufshcd-pltfrm.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-
> pltfrm.c
> index 87975d1a21c8..cca4b2181a81 100644
> --- a/drivers/scsi/ufs/ufshcd-pltfrm.c
> +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
> @@ -341,7 +341,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
> 
>  	err = ufshcd_alloc_host(dev, &hba);
>  	if (err) {
> -		dev_err(&pdev->dev, "Allocation failed\n");
> +		dev_err(dev, "Allocation failed\n");
>  		goto out;
>  	}
> 
> @@ -349,13 +349,13 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
> 
>  	err = ufshcd_parse_clock_info(hba);
>  	if (err) {
> -		dev_err(&pdev->dev, "%s: clock parse failed %d\n",
> +		dev_err(dev, "%s: clock parse failed %d\n",
>  				__func__, err);
>  		goto dealloc_host;
>  	}
>  	err = ufshcd_parse_regulator_info(hba);
>  	if (err) {
> -		dev_err(&pdev->dev, "%s: regulator init failed %d\n",
> +		dev_err(dev, "%s: regulator init failed %d\n",
>  				__func__, err);
>  		goto dealloc_host;
>  	}
> @@ -368,8 +368,8 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
>  		goto dealloc_host;
>  	}
> 
> -	pm_runtime_set_active(&pdev->dev);
> -	pm_runtime_enable(&pdev->dev);
> +	pm_runtime_set_active(dev);
> +	pm_runtime_enable(dev);
> 
>  	return 0;
> 
> --
> 2.32.0

Re: [PATCH] scsi: ufs: ufshcd-pltfrm: simplify usages of pdev->dev

[Martin K. Petersen]

Krzysztof,

> The 'struct device' pointer is already cached as local variable in
> ufshcd_pltfrm_init(), so use it.

Applied to 5.19/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering