From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: David Disseldorp <ddiss@suse.de>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, bvanassche@acm.org
Subject: Re: [PATCH] scsi: target/iblock: fix WRITE SAME zeroing
Date: Wed, 22 Apr 2020 04:02:42 +0000 [thread overview]
Message-ID: <yq1d080i2vx.fsf@oracle.com> (raw)
In-Reply-To: <20200419163109.11689-1-ddiss@suse.de> (David Disseldorp's message of "Sun, 19 Apr 2020 18:31:09 +0200")
David,
> SBC4 specifies that WRITE SAME requests with the UNMAP bit set to zero
> "shall perform the specified write operation to each LBA specified by
> the command".
> 2237498f0b5c modified the iblock backend to call blkdev_issue_zeroout()
> when handling WRITE SAME requests with UNMAP=0 and a zero data segment.
> The iblock blkdev_issue_zeroout() call incorrectly provides a flags
> parameter of 0 (bool false), instead of BLKDEV_ZERO_NOUNMAP. The bool
> false parameter reflects the blkdev_issue_zeroout() API prior to
> ee472d835c264, which was merged shortly before 2237498f0b5c.
Applied to 5.7/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: David Disseldorp <ddiss@suse.de>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, bvanassche@acm.org
Subject: Re: [PATCH] scsi: target/iblock: fix WRITE SAME zeroing
Date: Wed, 22 Apr 2020 00:02:42 -0400 [thread overview]
Message-ID: <yq1d080i2vx.fsf@oracle.com> (raw)
In-Reply-To: <20200419163109.11689-1-ddiss@suse.de> (David Disseldorp's message of "Sun, 19 Apr 2020 18:31:09 +0200")
David,
> SBC4 specifies that WRITE SAME requests with the UNMAP bit set to zero
> "shall perform the specified write operation to each LBA specified by
> the command".
> 2237498f0b5c modified the iblock backend to call blkdev_issue_zeroout()
> when handling WRITE SAME requests with UNMAP=0 and a zero data segment.
> The iblock blkdev_issue_zeroout() call incorrectly provides a flags
> parameter of 0 (bool false), instead of BLKDEV_ZERO_NOUNMAP. The bool
> false parameter reflects the blkdev_issue_zeroout() API prior to
> ee472d835c264, which was merged shortly before 2237498f0b5c.
Applied to 5.7/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-04-22 4:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 16:31 [PATCH] scsi: target/iblock: fix WRITE SAME zeroing David Disseldorp
2020-04-19 16:31 ` David Disseldorp
2020-04-19 23:45 ` Bart Van Assche
2020-04-19 23:45 ` Bart Van Assche
2020-04-22 4:02 ` Martin K. Petersen [this message]
2020-04-22 4:02 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d080i2vx.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=ddiss@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.