* [PATCH-next] ibmvfc: Remove unneeded semicolons
@ 2018-01-18 1:38 Christopher Díaz Riveros
2018-01-18 18:56 ` Tyrel Datwyler
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Christopher Díaz Riveros @ 2018-01-18 1:38 UTC (permalink / raw)
To: jejb, martin.petersen, tyreld, benh, paulus, mpe
Cc: linux-scsi, Christopher Díaz Riveros
Trivial fix removes unneeded semicolons after switch blocks.
This issue was detected by using the Coccinelle software.
Signed-off-by: Christopher Díaz Riveros <chrisadr@gentoo.org>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 0d2f7eb3acb6..b1b1d3a3b173 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -181,7 +181,7 @@ static void ibmvfc_trc_start(struct ibmvfc_event *evt)
break;
default:
break;
- };
+ }
}
/**
@@ -220,7 +220,7 @@ static void ibmvfc_trc_end(struct ibmvfc_event *evt)
default:
break;
- };
+ }
}
#else
@@ -464,7 +464,7 @@ static int ibmvfc_set_host_state(struct ibmvfc_host *vhost,
default:
vhost->state = state;
break;
- };
+ }
return rc;
}
@@ -500,7 +500,7 @@ static void ibmvfc_set_host_action(struct ibmvfc_host *vhost,
break;
default:
break;
- };
+ }
break;
case IBMVFC_HOST_ACTION_TGT_INIT:
if (vhost->action == IBMVFC_HOST_ACTION_ALLOC_TGTS)
@@ -515,7 +515,7 @@ static void ibmvfc_set_host_action(struct ibmvfc_host *vhost,
default:
vhost->action = action;
break;
- };
+ }
break;
case IBMVFC_HOST_ACTION_LOGO:
case IBMVFC_HOST_ACTION_QUERY_TGTS:
@@ -526,7 +526,7 @@ static void ibmvfc_set_host_action(struct ibmvfc_host *vhost,
default:
vhost->action = action;
break;
- };
+ }
}
/**
@@ -1601,7 +1601,7 @@ static inline int ibmvfc_host_chkready(struct ibmvfc_host *vhost)
case IBMVFC_ACTIVE:
result = 0;
break;
- };
+ }
return result;
}
@@ -1856,7 +1856,7 @@ static int ibmvfc_bsg_request(struct bsg_job *job)
break;
default:
return -ENOTSUPP;
- };
+ }
if (port_id == -1)
return -EINVAL;
@@ -2661,7 +2661,7 @@ static void ibmvfc_handle_async(struct ibmvfc_async_crq *crq,
vhost->delay_init = 1;
__ibmvfc_reset_host(vhost);
break;
- };
+ }
break;
case IBMVFC_AE_LINK_UP:
@@ -2715,7 +2715,7 @@ static void ibmvfc_handle_async(struct ibmvfc_async_crq *crq,
default:
dev_err(vhost->dev, "Unknown async event received: %lld\n", crq->event);
break;
- };
+ }
}
/**
@@ -3351,7 +3351,7 @@ static void ibmvfc_tgt_prli_done(struct ibmvfc_event *evt)
ibmvfc_get_cmd_error(be16_to_cpu(rsp->status), be16_to_cpu(rsp->error)),
rsp->status, rsp->error, status);
break;
- };
+ }
kref_put(&tgt->kref, ibmvfc_release_tgt);
ibmvfc_free_event(evt);
@@ -3451,7 +3451,7 @@ static void ibmvfc_tgt_plogi_done(struct ibmvfc_event *evt)
ibmvfc_get_fc_type(be16_to_cpu(rsp->fc_type)), rsp->fc_type,
ibmvfc_get_ls_explain(be16_to_cpu(rsp->fc_explain)), rsp->fc_explain, status);
break;
- };
+ }
kref_put(&tgt->kref, ibmvfc_release_tgt);
ibmvfc_free_event(evt);
@@ -3522,7 +3522,7 @@ static void ibmvfc_tgt_implicit_logout_done(struct ibmvfc_event *evt)
default:
tgt_err(tgt, "Implicit Logout failed: rc=0x%02X\n", status);
break;
- };
+ }
if (vhost->action == IBMVFC_HOST_ACTION_TGT_INIT)
ibmvfc_init_tgt(tgt, ibmvfc_tgt_send_plogi);
@@ -3626,7 +3626,7 @@ static void ibmvfc_tgt_adisc_done(struct ibmvfc_event *evt)
ibmvfc_get_fc_type(fc_reason), fc_reason,
ibmvfc_get_ls_explain(fc_explain), fc_explain, status);
break;
- };
+ }
kref_put(&tgt->kref, ibmvfc_release_tgt);
ibmvfc_free_event(evt);
@@ -3838,7 +3838,7 @@ static void ibmvfc_tgt_query_target_done(struct ibmvfc_event *evt)
rsp->fc_type, ibmvfc_get_gs_explain(be16_to_cpu(rsp->fc_explain)),
rsp->fc_explain, status);
break;
- };
+ }
kref_put(&tgt->kref, ibmvfc_release_tgt);
ibmvfc_free_event(evt);
@@ -4236,7 +4236,7 @@ static int __ibmvfc_work_to_do(struct ibmvfc_host *vhost)
case IBMVFC_HOST_ACTION_REENABLE:
default:
break;
- };
+ }
return 1;
}
@@ -4464,7 +4464,7 @@ static void ibmvfc_do_work(struct ibmvfc_host *vhost)
break;
default:
break;
- };
+ }
spin_unlock_irqrestore(vhost->host->host_lock, flags);
}
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH-next] ibmvfc: Remove unneeded semicolons
2018-01-18 1:38 [PATCH-next] ibmvfc: Remove unneeded semicolons Christopher Díaz Riveros
@ 2018-01-18 18:56 ` Tyrel Datwyler
2018-01-18 18:57 ` Tyrel Datwyler
2018-01-19 2:36 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Tyrel Datwyler @ 2018-01-18 18:56 UTC (permalink / raw)
To: Christopher Díaz Riveros, jejb, martin.petersen, tyreld,
benh, paulus, mpe
Cc: linux-scsi
On 01/17/2018 05:38 PM, Christopher Díaz Riveros wrote:
> Trivial fix removes unneeded semicolons after switch blocks.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Christopher Díaz Riveros <chrisadr@gentoo.org>
> ---
Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH-next] ibmvfc: Remove unneeded semicolons
2018-01-18 1:38 [PATCH-next] ibmvfc: Remove unneeded semicolons Christopher Díaz Riveros
2018-01-18 18:56 ` Tyrel Datwyler
@ 2018-01-18 18:57 ` Tyrel Datwyler
2018-01-19 2:36 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Tyrel Datwyler @ 2018-01-18 18:57 UTC (permalink / raw)
To: Christopher Díaz Riveros, jejb, martin.petersen, tyreld,
benh, paulus, mpe
Cc: linux-scsi
On 01/17/2018 05:38 PM, Christopher Díaz Riveros wrote:
> Trivial fix removes unneeded semicolons after switch blocks.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Christopher Díaz Riveros <chrisadr@gentoo.org>
> ---
Resending from the correct email address. :)
Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH-next] ibmvfc: Remove unneeded semicolons
2018-01-18 1:38 [PATCH-next] ibmvfc: Remove unneeded semicolons Christopher Díaz Riveros
2018-01-18 18:56 ` Tyrel Datwyler
2018-01-18 18:57 ` Tyrel Datwyler
@ 2018-01-19 2:36 ` Martin K. Petersen
2018-01-19 3:27 ` Christopher Díaz Riveros
2 siblings, 1 reply; 5+ messages in thread
From: Martin K. Petersen @ 2018-01-19 2:36 UTC (permalink / raw)
To: Christopher Díaz Riveros
Cc: jejb, martin.petersen, tyreld, benh, paulus, mpe, linux-scsi
Christopher,
> Trivial fix removes unneeded semicolons after switch blocks.
Applied to 4.16/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH-next] ibmvfc: Remove unneeded semicolons
2018-01-19 2:36 ` Martin K. Petersen
@ 2018-01-19 3:27 ` Christopher Díaz Riveros
0 siblings, 0 replies; 5+ messages in thread
From: Christopher Díaz Riveros @ 2018-01-19 3:27 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: jejb, tyreld, benh, paulus, mpe, linux-scsi
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
El jue, 18-01-2018 a las 21:36 -0500, Martin K. Petersen escribió:
> Christopher,
>
> > Trivial fix removes unneeded semicolons after switch blocks.
>
> Applied to 4.16/scsi-queue.
>
Thank you very much Martin and Tyrel,
Sorry if it's a very tiny trivial patch, but I'm still learning all the
submitting patch procedures and is actually my second patch accepted :)
Regards,
--
Christopher Díaz Riveros
Gentoo Linux Developer
GPG Fingerprint: E517 5ECB 8152 98E4 FEBC 2BAA 4DBB D10F 0FDD 2547
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 636 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-19 3:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-18 1:38 [PATCH-next] ibmvfc: Remove unneeded semicolons Christopher Díaz Riveros
2018-01-18 18:56 ` Tyrel Datwyler
2018-01-18 18:57 ` Tyrel Datwyler
2018-01-19 2:36 ` Martin K. Petersen
2018-01-19 3:27 ` Christopher Díaz Riveros
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.