* [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error
@ 2017-12-19 18:32 ` Cathy Avery
0 siblings, 0 replies; 5+ messages in thread
From: Cathy Avery @ 2017-12-19 18:32 UTC (permalink / raw)
To: kys, jejb, martin.petersen
Cc: sthemmin, haiyangz, devel, linux-kernel, linux-scsi, longli
When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
which has zero good_bytes it must be assigned an error. Otherwise
the I/O will be continuously requeued and will cause a deadlock in the
case where disks are being hot added and removed. sd_probe_async will
wait forever for its I/O to complete while holding scsi_sd_probe_domain.
Also returning the default error of DID_TARGET_FAILURE causes
multipath to not retry the I/O resulting in applications receiving I/O
errors before a failover can occur.
Signed-off-by: Cathy Avery <cavery@redhat.com>
Signed-off-by: Long Li <longli@microsoft.com>
---
drivers/scsi/storvsc_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 1b06cf0..3b3d1d0 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -953,10 +953,11 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb,
case TEST_UNIT_READY:
break;
default:
- set_host_byte(scmnd, DID_TARGET_FAILURE);
+ set_host_byte(scmnd, DID_ERROR);
}
break;
case SRB_STATUS_INVALID_LUN:
+ set_host_byte(scmnd, DID_NO_CONNECT);
do_work = true;
process_err_fn = storvsc_remove_lun;
break;
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error
@ 2017-12-19 18:32 ` Cathy Avery
0 siblings, 0 replies; 5+ messages in thread
From: Cathy Avery @ 2017-12-19 18:32 UTC (permalink / raw)
To: kys, jejb, martin.petersen
Cc: sthemmin, linux-scsi, haiyangz, linux-kernel, devel
When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
which has zero good_bytes it must be assigned an error. Otherwise
the I/O will be continuously requeued and will cause a deadlock in the
case where disks are being hot added and removed. sd_probe_async will
wait forever for its I/O to complete while holding scsi_sd_probe_domain.
Also returning the default error of DID_TARGET_FAILURE causes
multipath to not retry the I/O resulting in applications receiving I/O
errors before a failover can occur.
Signed-off-by: Cathy Avery <cavery@redhat.com>
Signed-off-by: Long Li <longli@microsoft.com>
---
drivers/scsi/storvsc_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 1b06cf0..3b3d1d0 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -953,10 +953,11 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb,
case TEST_UNIT_READY:
break;
default:
- set_host_byte(scmnd, DID_TARGET_FAILURE);
+ set_host_byte(scmnd, DID_ERROR);
}
break;
case SRB_STATUS_INVALID_LUN:
+ set_host_byte(scmnd, DID_NO_CONNECT);
do_work = true;
process_err_fn = storvsc_remove_lun;
break;
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error
2017-12-19 18:32 ` Cathy Avery
(?)
@ 2017-12-19 18:37 ` Stephen Hemminger
-1 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2017-12-19 18:37 UTC (permalink / raw)
To: Cathy Avery
Cc: kys, jejb, martin.petersen, sthemmin, linux-scsi, haiyangz,
linux-kernel, devel
On Tue, 19 Dec 2017 13:32:48 -0500
Cathy Avery <cavery@redhat.com> wrote:
> When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
> which has zero good_bytes it must be assigned an error. Otherwise
> the I/O will be continuously requeued and will cause a deadlock in the
> case where disks are being hot added and removed. sd_probe_async will
> wait forever for its I/O to complete while holding scsi_sd_probe_domain.
>
> Also returning the default error of DID_TARGET_FAILURE causes
> multipath to not retry the I/O resulting in applications receiving I/O
> errors before a failover can occur.
>
> Signed-off-by: Cathy Avery <cavery@redhat.com>
> Signed-off-by: Long Li <longli@microsoft.com>
When working on the DVD probe issue I saw that error handling was
problematic. Thanks for fixing.
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error
2017-12-19 18:32 ` Cathy Avery
@ 2017-12-21 2:24 ` Martin K. Petersen
-1 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2017-12-21 2:24 UTC (permalink / raw)
To: Cathy Avery
Cc: kys, jejb, martin.petersen, sthemmin, haiyangz, devel,
linux-kernel, linux-scsi, longli
Cathy,
> When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
> which has zero good_bytes it must be assigned an error. Otherwise the
> I/O will be continuously requeued and will cause a deadlock in the
> case where disks are being hot added and removed. sd_probe_async will
> wait forever for its I/O to complete while holding
> scsi_sd_probe_domain.
>
> Also returning the default error of DID_TARGET_FAILURE causes
> multipath to not retry the I/O resulting in applications receiving I/O
> errors before a failover can occur.
Applied to 4.15/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error
@ 2017-12-21 2:24 ` Martin K. Petersen
0 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2017-12-21 2:24 UTC (permalink / raw)
To: Cathy Avery
Cc: sthemmin, linux-scsi, martin.petersen, haiyangz, linux-kernel,
devel, jejb
Cathy,
> When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
> which has zero good_bytes it must be assigned an error. Otherwise the
> I/O will be continuously requeued and will cause a deadlock in the
> case where disks are being hot added and removed. sd_probe_async will
> wait forever for its I/O to complete while holding
> scsi_sd_probe_domain.
>
> Also returning the default error of DID_TARGET_FAILURE causes
> multipath to not retry the I/O resulting in applications receiving I/O
> errors before a failover can occur.
Applied to 4.15/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-21 2:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-19 18:32 [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error Cathy Avery
2017-12-19 18:32 ` Cathy Avery
2017-12-19 18:37 ` Stephen Hemminger
2017-12-21 2:24 ` Martin K. Petersen
2017-12-21 2:24 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.