From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: keith.busch@intel.com, linux-nvme@lists.infradead.org,
sagi@grimberg.me, hch@lst.de, martin.petersen@oracle.com,
linux-block@vger.kernel.org, axboe@kernel.dk,
vladimirk@mellanox.com
Subject: Re: [PATCH v4 2/3] block: move dif_prepare/dif_complete functions to block layer
Date: Wed, 25 Jul 2018 21:12:27 -0400 [thread overview]
Message-ID: <yq1k1pi3imc.fsf@oracle.com> (raw)
In-Reply-To: <1532533577-1600-2-git-send-email-maxg@mellanox.com> (Max Gurtovoy's message of "Wed, 25 Jul 2018 18:46:16 +0300")
Max,
> Currently these functions are implemented in the scsi layer, but their
> actual place should be the block layer since T10-PI is a general data
> integrity feature that is used in the nvme protocol as well. Also, use
> the tuple size from the integrity profile since it may vary between
> integrity types.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH v4 2/3] block: move dif_prepare/dif_complete functions to block layer
Date: Wed, 25 Jul 2018 21:12:27 -0400 [thread overview]
Message-ID: <yq1k1pi3imc.fsf@oracle.com> (raw)
In-Reply-To: <1532533577-1600-2-git-send-email-maxg@mellanox.com> (Max Gurtovoy's message of "Wed, 25 Jul 2018 18:46:16 +0300")
Max,
> Currently these functions are implemented in the scsi layer, but their
> actual place should be the block layer since T10-PI is a general data
> integrity feature that is used in the nvme protocol as well. Also, use
> the tuple size from the integrity profile since it may vary between
> integrity types.
Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-07-26 1:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 15:46 [PATCH v4 1/3] block: move ref_tag calculation func to the block layer Max Gurtovoy
2018-07-25 15:46 ` Max Gurtovoy
2018-07-25 15:46 ` [PATCH v4 2/3] block: move dif_prepare/dif_complete functions to " Max Gurtovoy
2018-07-25 15:46 ` Max Gurtovoy
2018-07-26 1:12 ` Martin K. Petersen [this message]
2018-07-26 1:12 ` Martin K. Petersen
2018-07-25 15:46 ` [PATCH v4 3/3] nvme: use blk API to remap ref tags for IOs with metadata Max Gurtovoy
2018-07-25 15:46 ` Max Gurtovoy
2018-07-25 17:58 ` Keith Busch
2018-07-25 17:58 ` Keith Busch
2018-07-26 1:12 ` Martin K. Petersen
2018-07-26 1:12 ` Martin K. Petersen
2018-07-26 1:11 ` [PATCH v4 1/3] block: move ref_tag calculation func to the block layer Martin K. Petersen
2018-07-26 1:11 ` Martin K. Petersen
2018-07-27 15:21 ` Jens Axboe
2018-07-27 15:21 ` Jens Axboe
2018-07-27 15:38 ` Jens Axboe
2018-07-27 15:38 ` Jens Axboe
2018-07-28 22:12 ` Max Gurtovoy
2018-07-28 22:12 ` Max Gurtovoy
2018-07-28 22:22 ` Jens Axboe
2018-07-28 22:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1k1pi3imc.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=vladimirk@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.