All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] initio: don't use GFP_DMA in initio_probe_one
@ 2021-12-22  9:16 Christoph Hellwig
  2021-12-23  4:45 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2021-12-22  9:16 UTC (permalink / raw)
  To: martin.petersen; +Cc: linux-scsi

The driver doesn't express DMA addressing limitation under 32-bits
anywhere else, so remove the spurious GFP_DMA allocation.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/scsi/initio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
index 9cdee38f5ba33..5f96ac47d7fd1 100644
--- a/drivers/scsi/initio.c
+++ b/drivers/scsi/initio.c
@@ -2847,7 +2847,8 @@ static int initio_probe_one(struct pci_dev *pdev,
 
 	for (; num_scb >= MAX_TARGETS + 3; num_scb--) {
 		i = num_scb * sizeof(struct scsi_ctrl_blk);
-		if ((scb = kzalloc(i, GFP_DMA)) != NULL)
+		scb = kzalloc(i, GFP_KERNEL);
+		if (scb)
 			break;
 	}
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] initio: don't use GFP_DMA in initio_probe_one
  2021-12-22  9:16 [PATCH] initio: don't use GFP_DMA in initio_probe_one Christoph Hellwig
@ 2021-12-23  4:45 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-12-23  4:45 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: martin.petersen, linux-scsi


Christoph,

> The driver doesn't express DMA addressing limitation under 32-bits
> anywhere else, so remove the spurious GFP_DMA allocation.

Applied to 5.17/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-23  4:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-22  9:16 [PATCH] initio: don't use GFP_DMA in initio_probe_one Christoph Hellwig
2021-12-23  4:45 ` Martin K. Petersen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.