* Re: [PATCH] scsi: libsas: remove unused variable sas_ha
2017-09-26 19:17 ` Colin King
(?)
@ 2017-09-26 14:38 ` John Garry
-1 siblings, 0 replies; 7+ messages in thread
From: John Garry @ 2017-09-26 14:38 UTC (permalink / raw)
To: Colin King, James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel, yanaijie
On 26/09/2017 20:17, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove unused variable sas_ha to clean up build warning
> "unused variable ‘sas_ha’ [-Wunused-variable]"
>
> Fixes: 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: John Garry <john.garry@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 29d6cb39299c..9e2990268f00 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -1046,7 +1046,6 @@ static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 old_state,
>
> static int hisi_sas_controller_reset(struct hisi_hba *hisi_hba)
> {
> - struct sas_ha_struct *sas_ha = &hisi_hba->sha;
> struct device *dev = hisi_hba->dev;
> struct Scsi_Host *shost = hisi_hba->shost;
> u32 old_state, state;
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: libsas: remove unused variable sas_ha
@ 2017-09-26 14:38 ` John Garry
0 siblings, 0 replies; 7+ messages in thread
From: John Garry @ 2017-09-26 14:38 UTC (permalink / raw)
To: Colin King, James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel, yanaijie
On 26/09/2017 20:17, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove unused variable sas_ha to clean up build warning
> "unused variable ‘sas_ha’ [-Wunused-variable]"
>
> Fixes: 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: John Garry <john.garry@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 29d6cb39299c..9e2990268f00 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -1046,7 +1046,6 @@ static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 old_state,
>
> static int hisi_sas_controller_reset(struct hisi_hba *hisi_hba)
> {
> - struct sas_ha_struct *sas_ha = &hisi_hba->sha;
> struct device *dev = hisi_hba->dev;
> struct Scsi_Host *shost = hisi_hba->shost;
> u32 old_state, state;
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: libsas: remove unused variable sas_ha
@ 2017-09-26 14:38 ` John Garry
0 siblings, 0 replies; 7+ messages in thread
From: John Garry @ 2017-09-26 14:38 UTC (permalink / raw)
To: Colin King, James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel, yanaijie
On 26/09/2017 20:17, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove unused variable sas_ha to clean up build warning
> "unused variable ‘sas_ha’ [-Wunused-variable]"
>
> Fixes: 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: John Garry <john.garry@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 29d6cb39299c..9e2990268f00 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -1046,7 +1046,6 @@ static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 old_state,
>
> static int hisi_sas_controller_reset(struct hisi_hba *hisi_hba)
> {
> - struct sas_ha_struct *sas_ha = &hisi_hba->sha;
> struct device *dev = hisi_hba->dev;
> struct Scsi_Host *shost = hisi_hba->shost;
> u32 old_state, state;
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] scsi: libsas: remove unused variable sas_ha
2017-09-26 14:38 ` John Garry
@ 2017-09-26 19:17 ` Colin King
-1 siblings, 0 replies; 7+ messages in thread
From: Colin King @ 2017-09-26 19:17 UTC (permalink / raw)
To: John Garry, James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Remove unused variable sas_ha to clean up build warning
"unused variable ‘sas_ha’ [-Wunused-variable]"
Fixes: 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 29d6cb39299c..9e2990268f00 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -1046,7 +1046,6 @@ static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 old_state,
static int hisi_sas_controller_reset(struct hisi_hba *hisi_hba)
{
- struct sas_ha_struct *sas_ha = &hisi_hba->sha;
struct device *dev = hisi_hba->dev;
struct Scsi_Host *shost = hisi_hba->shost;
u32 old_state, state;
--
2.14.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] scsi: libsas: remove unused variable sas_ha
@ 2017-09-26 19:17 ` Colin King
0 siblings, 0 replies; 7+ messages in thread
From: Colin King @ 2017-09-26 19:17 UTC (permalink / raw)
To: John Garry, James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Remove unused variable sas_ha to clean up build warning
"unused variable ‘sas_ha’ [-Wunused-variable]"
Fixes: 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 29d6cb39299c..9e2990268f00 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -1046,7 +1046,6 @@ static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 old_state,
static int hisi_sas_controller_reset(struct hisi_hba *hisi_hba)
{
- struct sas_ha_struct *sas_ha = &hisi_hba->sha;
struct device *dev = hisi_hba->dev;
struct Scsi_Host *shost = hisi_hba->shost;
u32 old_state, state;
--
2.14.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: libsas: remove unused variable sas_ha
2017-09-26 19:17 ` Colin King
@ 2017-09-28 1:50 ` Martin K. Petersen
-1 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2017-09-28 1:50 UTC (permalink / raw)
To: Colin King
Cc: John Garry, James E . J . Bottomley, Martin K . Petersen,
linux-scsi, kernel-janitors, linux-kernel
Colin,
> Remove unused variable sas_ha to clean up build warning
> "unused variable ‘sas_ha’ [-Wunused-variable]"
Applied to 4.15/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: libsas: remove unused variable sas_ha
@ 2017-09-28 1:50 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2017-09-28 1:50 UTC (permalink / raw)
To: Colin King
Cc: John Garry, James E . J . Bottomley, Martin K . Petersen,
linux-scsi, kernel-janitors, linux-kernel
Colin,
> Remove unused variable sas_ha to clean up build warning
> "unused variable ‘sas_ha’ [-Wunused-variable]"
Applied to 4.15/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-09-28 1:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-26 19:17 [PATCH] scsi: libsas: remove unused variable sas_ha Colin King
2017-09-26 19:17 ` Colin King
2017-09-26 14:38 ` John Garry
2017-09-26 14:38 ` John Garry
2017-09-26 14:38 ` John Garry
2017-09-28 1:50 ` Martin K. Petersen
2017-09-28 1:50 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.