* [PATCH] mpt3sas: Fix Coverity reported issue.
@ 2021-06-18 15:55 Suganath Prabu S
2021-06-19 2:47 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Suganath Prabu S @ 2021-06-18 15:55 UTC (permalink / raw)
To: linux-scsi, martin.petersen
Cc: Sathya.Prakash, sreekanth.reddy, Suganath Prabu S, Colin Ian King
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
Fix the Structurally dead code (UNREACHABLE) type of error
reported by coverity.
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@broadcom.com>
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index e592b1a..75e5c6c 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -7206,6 +7206,7 @@ mpt3sas_port_enable_done(struct MPT3SAS_ADAPTER *ioc, u16 smid, u8 msix_index,
ioc->port_enable_failed = 1;
if (ioc->port_enable_cmds.status & MPT3_CMD_COMPLETE_ASYNC) {
+ ioc->port_enable_cmds.status &= ~MPT3_CMD_COMPLETE_ASYNC;
if (ioc_status == MPI2_IOCSTATUS_SUCCESS) {
mpt3sas_port_enable_complete(ioc);
return 1;
@@ -7214,7 +7215,6 @@ mpt3sas_port_enable_done(struct MPT3SAS_ADAPTER *ioc, u16 smid, u8 msix_index,
ioc->start_scan = 0;
return 1;
}
- ioc->port_enable_cmds.status &= ~MPT3_CMD_COMPLETE_ASYNC;
}
complete(&ioc->port_enable_cmds.done);
return 1;
--
2.27.0
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4245 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mpt3sas: Fix Coverity reported issue.
2021-06-18 15:55 [PATCH] mpt3sas: Fix Coverity reported issue Suganath Prabu S
@ 2021-06-19 2:47 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-06-19 2:47 UTC (permalink / raw)
To: Suganath Prabu S
Cc: linux-scsi, martin.petersen, Sathya.Prakash, sreekanth.reddy,
Colin Ian King
Suganath,
> Fix the Structurally dead code (UNREACHABLE) type of error reported by
> coverity.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-19 2:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 15:55 [PATCH] mpt3sas: Fix Coverity reported issue Suganath Prabu S
2021-06-19 2:47 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.