From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jan Kotas <jank@cadence.com>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
<alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
<pedrom.sousa@synopsys.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2/2] scsi: ufs-cdns: Add support for UFSHCI with M31 PHY
Date: Wed, 03 Apr 2019 23:24:17 -0400 [thread overview]
Message-ID: <yq1mul6tpum.fsf@oracle.com> (raw)
In-Reply-To: <20190327144405.5716-3-jank@cadence.com> (Jan Kotas's message of "Wed, 27 Mar 2019 14:44:05 +0000")
Jan,
> + if (hba->vops && hba->vops->phy_initialization) {
> + status = hba->vops->phy_initialization(hba);
> + if (status)
> + return status;
> + }
> +
> + return status;
I zapped the superfluous return conditional. Applied patches 1 and 2 to
5.2/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jan Kotas <jank@cadence.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
alim.akhtar@samsung.com, avri.altman@wdc.com,
pedrom.sousa@synopsys.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] scsi: ufs-cdns: Add support for UFSHCI with M31 PHY
Date: Wed, 03 Apr 2019 23:24:17 -0400 [thread overview]
Message-ID: <yq1mul6tpum.fsf@oracle.com> (raw)
In-Reply-To: <20190327144405.5716-3-jank@cadence.com> (Jan Kotas's message of "Wed, 27 Mar 2019 14:44:05 +0000")
Jan,
> + if (hba->vops && hba->vops->phy_initialization) {
> + status = hba->vops->phy_initialization(hba);
> + if (status)
> + return status;
> + }
> +
> + return status;
I zapped the superfluous return conditional. Applied patches 1 and 2 to
5.2/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-04-04 3:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 14:44 [PATCH 0/2] scsi: ufs-cdns: Add M31 PHY init Jan Kotas
2019-03-27 14:44 ` Jan Kotas
2019-03-27 14:44 ` [PATCH 1/2] dt-bindings: scsi: ufs-cdns: Update Cadence UFS compatibility list Jan Kotas
2019-03-27 14:44 ` Jan Kotas
2019-03-31 6:42 ` Rob Herring
2019-04-01 7:49 ` Jan Kotas
2019-04-03 4:15 ` Rob Herring
2019-03-27 14:44 ` [PATCH 2/2] scsi: ufs-cdns: Add support for UFSHCI with M31 PHY Jan Kotas
2019-03-27 14:44 ` Jan Kotas
2019-04-04 3:24 ` Martin K. Petersen [this message]
2019-04-04 3:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1mul6tpum.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=jank@cadence.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pedrom.sousa@synopsys.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.