* [PATCH] scsi: isci: make scu_link_layer_set_txcomsas_timeout() static
@ 2020-09-15 8:40 Jason Yan
2020-09-16 1:30 ` Martin K. Petersen
2020-09-22 3:57 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-09-15 8:40 UTC (permalink / raw)
To: intel-linux-scu, artur.paszkiewicz, jejb, martin.petersen, linux-scsi
Cc: Jason Yan, Hulk Robot
This addresses the following sparse warning:
drivers/scsi/isci/phy.c:672:6: warning: symbol
'scu_link_layer_set_txcomsas_timeout' was not declared. Should it be
static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/isci/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/isci/phy.c b/drivers/scsi/isci/phy.c
index 4cacb800b530..7041e2e3ab48 100644
--- a/drivers/scsi/isci/phy.c
+++ b/drivers/scsi/isci/phy.c
@@ -669,7 +669,7 @@ static const char *phy_event_name(u32 event_code)
phy_state_name(state), phy_event_name(code), code)
-void scu_link_layer_set_txcomsas_timeout(struct isci_phy *iphy, u32 timeout)
+static void scu_link_layer_set_txcomsas_timeout(struct isci_phy *iphy, u32 timeout)
{
u32 val;
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: isci: make scu_link_layer_set_txcomsas_timeout() static
2020-09-15 8:40 [PATCH] scsi: isci: make scu_link_layer_set_txcomsas_timeout() static Jason Yan
@ 2020-09-16 1:30 ` Martin K. Petersen
2020-09-22 3:57 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-09-16 1:30 UTC (permalink / raw)
To: Jason Yan
Cc: intel-linux-scu, artur.paszkiewicz, jejb, martin.petersen,
linux-scsi, Hulk Robot
Jason,
> This addresses the following sparse warning:
>
> drivers/scsi/isci/phy.c:672:6: warning: symbol
> 'scu_link_layer_set_txcomsas_timeout' was not declared. Should it be
> static?
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: isci: make scu_link_layer_set_txcomsas_timeout() static
2020-09-15 8:40 [PATCH] scsi: isci: make scu_link_layer_set_txcomsas_timeout() static Jason Yan
2020-09-16 1:30 ` Martin K. Petersen
@ 2020-09-22 3:57 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-09-22 3:57 UTC (permalink / raw)
To: linux-scsi, intel-linux-scu, Jason Yan, artur.paszkiewicz, jejb
Cc: Martin K . Petersen, Hulk Robot
On Tue, 15 Sep 2020 16:40:00 +0800, Jason Yan wrote:
> This addresses the following sparse warning:
>
> drivers/scsi/isci/phy.c:672:6: warning: symbol
> 'scu_link_layer_set_txcomsas_timeout' was not declared. Should it be
> static?
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: isci: Make scu_link_layer_set_txcomsas_timeout() static
https://git.kernel.org/mkp/scsi/c/2494ebe1b3f7
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-22 3:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 8:40 [PATCH] scsi: isci: make scu_link_layer_set_txcomsas_timeout() static Jason Yan
2020-09-16 1:30 ` Martin K. Petersen
2020-09-22 3:57 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.