* [PATCH] scsi: libfc: fix ELS request handling
@ 2017-11-25 18:38 Martin Wilck
2017-11-27 8:16 ` Johannes Thumshirn
2017-11-29 4:59 ` Martin K. Petersen
0 siblings, 2 replies; 4+ messages in thread
From: Martin Wilck @ 2017-11-25 18:38 UTC (permalink / raw)
To: Johannes Thumshirn, Martin K. Petersen
Cc: Martin Wilck, linux-scsi, linux-kernel, stable, Chad Dupuis
The modification of fc_lport_recv_els_req() in commit fcabb09e59a7
(merged in 4.12-rc1) caused certain requests not to be handled at all.
Fix that.
Fixes: fcabb09e59a7 "scsi: libfc: directly call ELS request handlers"
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
drivers/scsi/libfc/fc_lport.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c
index 2fd0ec651170..787e82435241 100644
--- a/drivers/scsi/libfc/fc_lport.c
+++ b/drivers/scsi/libfc/fc_lport.c
@@ -904,10 +904,14 @@ static void fc_lport_recv_els_req(struct fc_lport *lport,
case ELS_FLOGI:
if (!lport->point_to_multipoint)
fc_lport_recv_flogi_req(lport, fp);
+ else
+ fc_rport_recv_req(lport, fp);
break;
case ELS_LOGO:
if (fc_frame_sid(fp) == FC_FID_FLOGI)
fc_lport_recv_logo_req(lport, fp);
+ else
+ fc_rport_recv_req(lport, fp);
break;
case ELS_RSCN:
lport->tt.disc_recv_req(lport, fp);
--
2.15.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: libfc: fix ELS request handling
2017-11-25 18:38 [PATCH] scsi: libfc: fix ELS request handling Martin Wilck
@ 2017-11-27 8:16 ` Johannes Thumshirn
2017-11-29 4:59 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Johannes Thumshirn @ 2017-11-27 8:16 UTC (permalink / raw)
To: Martin Wilck
Cc: Martin K. Petersen, Martin Wilck, linux-scsi, linux-kernel,
stable, Chad Dupuis
Thanks Martin,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: libfc: fix ELS request handling
@ 2017-11-27 8:16 ` Johannes Thumshirn
0 siblings, 0 replies; 4+ messages in thread
From: Johannes Thumshirn @ 2017-11-27 8:16 UTC (permalink / raw)
To: Martin Wilck
Cc: Martin K. Petersen, Martin Wilck, linux-scsi, linux-kernel,
stable, Chad Dupuis
Thanks Martin,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Felix Imend�rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N�rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: libfc: fix ELS request handling
2017-11-25 18:38 [PATCH] scsi: libfc: fix ELS request handling Martin Wilck
2017-11-27 8:16 ` Johannes Thumshirn
@ 2017-11-29 4:59 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2017-11-29 4:59 UTC (permalink / raw)
To: Martin Wilck
Cc: Johannes Thumshirn, Martin K. Petersen, Martin Wilck, linux-scsi,
linux-kernel, stable, Chad Dupuis
Martin,
> The modification of fc_lport_recv_els_req() in commit fcabb09e59a7
> (merged in 4.12-rc1) caused certain requests not to be handled at all.
> Fix that.
Applied to 4.15/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-29 4:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-25 18:38 [PATCH] scsi: libfc: fix ELS request handling Martin Wilck
2017-11-27 8:16 ` Johannes Thumshirn
2017-11-27 8:16 ` Johannes Thumshirn
2017-11-29 4:59 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.