[PATCH] libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk

[PATCH] libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk

[Hans de Goede]

We've received a bugreport that using LPM with ST1000LM024 drives leads
to system lockups. So it seems that these models are buggy in more then
1 way. Add NOLPM quirk to the existing quirks entry for BROKEN_FPDMA_AA.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1571330
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/ata/libata-core.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index aaa57e0c809d..4a2dff303865 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4460,9 +4460,12 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "ST3320[68]13AS",	"SD1[5-9]",	ATA_HORKAGE_NONCQ |
 						ATA_HORKAGE_FIRMWARE_WARN },
 
-	/* drives which fail FPDMA_AA activation (some may freeze afterwards) */
-	{ "ST1000LM024 HN-M101MBB", "2AR10001",	ATA_HORKAGE_BROKEN_FPDMA_AA },
-	{ "ST1000LM024 HN-M101MBB", "2BA30001",	ATA_HORKAGE_BROKEN_FPDMA_AA },
+	/* drives which fail FPDMA_AA activation (some may freeze afterwards)
+	   the ST disks also have LPM issues */
+	{ "ST1000LM024 HN-M101MBB", "2AR10001",	ATA_HORKAGE_BROKEN_FPDMA_AA |
+						ATA_HORKAGE_NOLPM, },
+	{ "ST1000LM024 HN-M101MBB", "2BA30001",	ATA_HORKAGE_BROKEN_FPDMA_AA |
+						ATA_HORKAGE_NOLPM, },
 	{ "VB0250EAVER",	"HPG7",		ATA_HORKAGE_BROKEN_FPDMA_AA },
 
 	/* Blacklist entries taken from Silicon Image 3124/3132
-- 
2.21.0

Re: [PATCH] libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk

[Martin K. Petersen]

Hans,

> -	/* drives which fail FPDMA_AA activation (some may freeze afterwards) */
> -	{ "ST1000LM024 HN-M101MBB", "2AR10001",	ATA_HORKAGE_BROKEN_FPDMA_AA },
> -	{ "ST1000LM024 HN-M101MBB", "2BA30001",	ATA_HORKAGE_BROKEN_FPDMA_AA },
> +	/* drives which fail FPDMA_AA activation (some may freeze afterwards)
> +	   the ST disks also have LPM issues */
> +	{ "ST1000LM024 HN-M101MBB", "2AR10001",	ATA_HORKAGE_BROKEN_FPDMA_AA |
> +						ATA_HORKAGE_NOLPM, },
> +	{ "ST1000LM024 HN-M101MBB", "2BA30001",	ATA_HORKAGE_BROKEN_FPDMA_AA |
> +						ATA_HORKAGE_NOLPM, },

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

Slightly orthogonal, and I know it's been discussed before, but I think
it would be worth considering just blacklisting all firmware revs for
this model.

There were several firmware releases for these drives. And while it's
conceivable that post-2BA30001 may fix the issues, I think it's safe to
say that all the intermediate releases between the two we have are
equally broken.

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk

[Hans de Goede]

Hi,

On 12-06-19 05:40, Martin K. Petersen wrote:
> 
> Hans,
> 
>> -	/* drives which fail FPDMA_AA activation (some may freeze afterwards) */
>> -	{ "ST1000LM024 HN-M101MBB", "2AR10001",	ATA_HORKAGE_BROKEN_FPDMA_AA },
>> -	{ "ST1000LM024 HN-M101MBB", "2BA30001",	ATA_HORKAGE_BROKEN_FPDMA_AA },
>> +	/* drives which fail FPDMA_AA activation (some may freeze afterwards)
>> +	   the ST disks also have LPM issues */
>> +	{ "ST1000LM024 HN-M101MBB", "2AR10001",	ATA_HORKAGE_BROKEN_FPDMA_AA |
>> +						ATA_HORKAGE_NOLPM, },
>> +	{ "ST1000LM024 HN-M101MBB", "2BA30001",	ATA_HORKAGE_BROKEN_FPDMA_AA |
>> +						ATA_HORKAGE_NOLPM, },
> 
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> 
> Slightly orthogonal, and I know it's been discussed before, but I think
> it would be worth considering just blacklisting all firmware revs for
> this model.
> 
> There were several firmware releases for these drives. And while it's
> conceivable that post-2BA30001 may fix the issues, I think it's safe to
> say that all the intermediate releases between the two we have are
> equally broken.

Dropping the firmware version sounds reasonable to me. Do you want me to
send a follow-up patch doing this?

Regards,

Hans

Re: [PATCH] libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk

[Martin K. Petersen]

Hans,

> Dropping the firmware version sounds reasonable to me. Do you want me to
> send a follow-up patch doing this?

Sure, that'd be great.

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk

[Jens Axboe]

On 6/11/19 8:32 AM, Hans de Goede wrote:
> We've received a bugreport that using LPM with ST1000LM024 drives leads
> to system lockups. So it seems that these models are buggy in more then
> 1 way. Add NOLPM quirk to the existing quirks entry for BROKEN_FPDMA_AA.

Applied, thanks.

-- 
Jens Axboe