* [PATCH v2] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs
[not found] <CGME20220811162118epcas5p2f452b3b425953d47e60e4b29868c03c9@epcas5p2.samsung.com>
@ 2022-08-11 16:10 ` Alim Akhtar
0 siblings, 0 replies; 6+ messages in thread
From: Alim Akhtar @ 2022-08-11 16:10 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, linux-scsi
Cc: krzysztof.kozlowski+dt, avri.altman, bvanassche, martin.petersen,
chanho61.park, linux-samsung-soc, Alim Akhtar
struct fsd_ufs_drvs is not used outside this file, so made it static.
This fixes sparse warning:
drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse:
symbol 'fsd_ufs_drvs' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 216f74e8059a ("scsi: ufs: host: ufs-exynos: Add support for FSD UFS HCI")
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
* Changes since v1
- Addressed Krzysztof's review comment
drivers/ufs/host/ufs-exynos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
index eced97538082..c3628a8645a5 100644
--- a/drivers/ufs/host/ufs-exynos.c
+++ b/drivers/ufs/host/ufs-exynos.c
@@ -1711,7 +1711,7 @@ static struct exynos_ufs_uic_attr fsd_uic_attr = {
.pa_dbg_option_suite = 0x2E820183,
};
-struct exynos_ufs_drv_data fsd_ufs_drvs = {
+static const struct exynos_ufs_drv_data fsd_ufs_drvs = {
.uic_attr = &fsd_uic_attr,
.quirks = UFSHCD_QUIRK_PRDT_BYTE_GRAN |
UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR |
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs
@ 2022-08-11 16:10 ` Alim Akhtar
0 siblings, 0 replies; 6+ messages in thread
From: Alim Akhtar @ 2022-08-11 16:10 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, linux-scsi
Cc: krzysztof.kozlowski+dt, avri.altman, bvanassche, martin.petersen,
chanho61.park, linux-samsung-soc, Alim Akhtar
struct fsd_ufs_drvs is not used outside this file, so made it static.
This fixes sparse warning:
drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse:
symbol 'fsd_ufs_drvs' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 216f74e8059a ("scsi: ufs: host: ufs-exynos: Add support for FSD UFS HCI")
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
* Changes since v1
- Addressed Krzysztof's review comment
drivers/ufs/host/ufs-exynos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
index eced97538082..c3628a8645a5 100644
--- a/drivers/ufs/host/ufs-exynos.c
+++ b/drivers/ufs/host/ufs-exynos.c
@@ -1711,7 +1711,7 @@ static struct exynos_ufs_uic_attr fsd_uic_attr = {
.pa_dbg_option_suite = 0x2E820183,
};
-struct exynos_ufs_drv_data fsd_ufs_drvs = {
+static const struct exynos_ufs_drv_data fsd_ufs_drvs = {
.uic_attr = &fsd_uic_attr,
.quirks = UFSHCD_QUIRK_PRDT_BYTE_GRAN |
UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR |
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs
2022-08-11 16:10 ` Alim Akhtar
@ 2022-08-11 16:54 ` Bart Van Assche
-1 siblings, 0 replies; 6+ messages in thread
From: Bart Van Assche @ 2022-08-11 16:54 UTC (permalink / raw)
To: Alim Akhtar, linux-arm-kernel, linux-kernel, linux-scsi
Cc: krzysztof.kozlowski+dt, avri.altman, martin.petersen,
chanho61.park, linux-samsung-soc
On 8/11/22 09:10, Alim Akhtar wrote:
> struct fsd_ufs_drvs is not used outside this file, so made it static.
> This fixes sparse warning:
>
> drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse:
> symbol 'fsd_ufs_drvs' was not declared. Should it be static?
`staticize' is not a verb. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs
@ 2022-08-11 16:54 ` Bart Van Assche
0 siblings, 0 replies; 6+ messages in thread
From: Bart Van Assche @ 2022-08-11 16:54 UTC (permalink / raw)
To: Alim Akhtar, linux-arm-kernel, linux-kernel, linux-scsi
Cc: krzysztof.kozlowski+dt, avri.altman, martin.petersen,
chanho61.park, linux-samsung-soc
On 8/11/22 09:10, Alim Akhtar wrote:
> struct fsd_ufs_drvs is not used outside this file, so made it static.
> This fixes sparse warning:
>
> drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse:
> symbol 'fsd_ufs_drvs' was not declared. Should it be static?
`staticize' is not a verb. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs
2022-08-11 16:10 ` Alim Akhtar
@ 2022-08-12 2:22 ` Martin K. Petersen
-1 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2022-08-12 2:22 UTC (permalink / raw)
To: Alim Akhtar
Cc: linux-arm-kernel, linux-kernel, linux-scsi,
krzysztof.kozlowski+dt, avri.altman, bvanassche, martin.petersen,
chanho61.park, linux-samsung-soc
Alim,
> struct fsd_ufs_drvs is not used outside this file, so made it static.
> This fixes sparse warning:
>
> drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse:
> symbol 'fsd_ufs_drvs' was not declared. Should it be static?
Applied to 5.20/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs
@ 2022-08-12 2:22 ` Martin K. Petersen
0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2022-08-12 2:22 UTC (permalink / raw)
To: Alim Akhtar
Cc: linux-arm-kernel, linux-kernel, linux-scsi,
krzysztof.kozlowski+dt, avri.altman, bvanassche, martin.petersen,
chanho61.park, linux-samsung-soc
Alim,
> struct fsd_ufs_drvs is not used outside this file, so made it static.
> This fixes sparse warning:
>
> drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse:
> symbol 'fsd_ufs_drvs' was not declared. Should it be static?
Applied to 5.20/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-12 2:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20220811162118epcas5p2f452b3b425953d47e60e4b29868c03c9@epcas5p2.samsung.com>
2022-08-11 16:10 ` [PATCH v2] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs Alim Akhtar
2022-08-11 16:10 ` Alim Akhtar
2022-08-11 16:54 ` Bart Van Assche
2022-08-11 16:54 ` Bart Van Assche
2022-08-12 2:22 ` Martin K. Petersen
2022-08-12 2:22 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.