* [PATCH] scsi_error.c: DID_SOFT_ERROR comment clean up
@ 2017-10-30 21:38 Petros Koutoupis
2017-10-31 16:47 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Petros Koutoupis @ 2017-10-30 21:38 UTC (permalink / raw)
To: jejb, martin.petersen; +Cc: linux-scsi
Updated comment. We are keeping track of maximum number of retries per command via
retries/allowed in struct scsi_cmnd. Corrected comment positioning.
Signed-off-by: Petros Koutoupis <petros@petroskoutoupis.com>
diff -uNpr linux-4.14-rc7.orig/drivers/scsi/scsi_error.c linux-4.14-rc7/drivers/scsi/scsi_error.c
--- linux-4.14-rc7.orig/drivers/scsi/scsi_error.c 2017-10-30 10:02:11.089576057 -0500
+++ linux-4.14-rc7/drivers/scsi/scsi_error.c 2017-10-30 10:08:24.352182353 -0500
@@ -1747,16 +1747,12 @@ int scsi_decide_disposition(struct scsi_
* that it indicates SUCCESS.
*/
return SUCCESS;
+ case DID_SOFT_ERROR:
/*
* when the low level driver returns did_soft_error,
* it is responsible for keeping an internal retry counter
* in order to avoid endless loops (db)
- *
- * actually this is a bug in this function here. we should
- * be mindful of the maximum number of retries specified
- * and not get stuck in a loop.
*/
- case DID_SOFT_ERROR:
goto maybe_retry;
case DID_IMM_RETRY:
return NEEDS_RETRY;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi_error.c: DID_SOFT_ERROR comment clean up
2017-10-30 21:38 [PATCH] scsi_error.c: DID_SOFT_ERROR comment clean up Petros Koutoupis
@ 2017-10-31 16:47 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2017-10-31 16:47 UTC (permalink / raw)
To: Petros Koutoupis; +Cc: jejb, martin.petersen, linux-scsi
Petros,
> Updated comment. We are keeping track of maximum number of retries per
> command via retries/allowed in struct scsi_cmnd. Corrected comment
> positioning.
This didn't apply to 4.15/scsi-queue. I applied it by hand.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-31 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-30 21:38 [PATCH] scsi_error.c: DID_SOFT_ERROR comment clean up Petros Koutoupis
2017-10-31 16:47 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.