* [PATCH] qla4xxx: drop redundant init_completion
@ 2017-03-22 10:44 Nicholas Mc Guire
2017-04-06 17:15 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2017-03-22 10:44 UTC (permalink / raw)
To: James E.J. Bottomley
Cc: Vikas Chaudhary, QLogic-Storage-Upstream, Martin K. Petersen,
linux-scsi, linux-kernel, Nicholas Mc Guire
The redundant init_completion() here seems to be a cut&past error as
struct scsi_qla_host only has 4 completion elements to initialize, thus
the duplicate init_completion(disable_acb_comp) is simply removed.
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
Found by experimental coccinelle script:
./drivers/scsi/qla4xxx/ql4_os.c:8667:1-16: WARNING: possible duplicate
init_completion
checking struct scsi_qla_host in
drivers/scsi/qla4xxx/ql4_def.h:457 "Linux Host Adapter structure"
it contain only the following 4 completion objects:
struct completion disable_acb_comp;
struct completion idc_comp;
struct completion link_up_comp;
struct completion mbx_intr_comp;
so it seems the double initialization of disable_acb_comp was just a
cut&past but and no omission of some other completion object - thus
the second initialization is simply removed.
Patch was only compile tested with: x86_64_defconfig + SCSI_LOWLEVEL=y,
CONFIG_SCSI_QLA_ISCSI=m
(...quite a few sparse and coccinelle errors/warnings during build-tests)
Patch is against 4.11-rc3 (localversion-next is next-20170322)
drivers/scsi/qla4xxx/ql4_os.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index ac52150..64c6fa5 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -8663,9 +8663,8 @@ static int qla4xxx_probe_adapter(struct pci_dev *pdev,
init_completion(&ha->mbx_intr_comp);
init_completion(&ha->disable_acb_comp);
init_completion(&ha->idc_comp);
init_completion(&ha->link_up_comp);
- init_completion(&ha->disable_acb_comp);
spin_lock_init(&ha->hardware_lock);
spin_lock_init(&ha->work_lock);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qla4xxx: drop redundant init_completion
2017-03-22 10:44 [PATCH] qla4xxx: drop redundant init_completion Nicholas Mc Guire
@ 2017-04-06 17:15 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2017-04-06 17:15 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: James E.J. Bottomley, Vikas Chaudhary, QLogic-Storage-Upstream,
Martin K. Petersen, linux-scsi, linux-kernel
Nicholas Mc Guire <der.herr@hofr.at> writes:
> The redundant init_completion() here seems to be a cut&past error as
> struct scsi_qla_host only has 4 completion elements to initialize,
> thus the duplicate init_completion(disable_acb_comp) is simply
> removed.
Applied to 4.12/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-06 17:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-22 10:44 [PATCH] qla4xxx: drop redundant init_completion Nicholas Mc Guire
2017-04-06 17:15 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.