* Re: [PATCH] scsi: lpfc: lpfc_nvmet.c: Fix Use plain integer as NULL pointer
[not found] <20191024030857.GA12097@saurav>
@ 2019-10-24 18:15 ` James Smart
2019-10-25 1:12 ` Martin K. Petersen
1 sibling, 0 replies; 2+ messages in thread
From: James Smart @ 2019-10-24 18:15 UTC (permalink / raw)
To: Saurav Girepunje, dick.kennedy, jejb, martin.petersen,
linux-scsi, linux-kernel
Cc: saurav.girepunje
On 10/23/2019 8:09 PM, Saurav Girepunje wrote:
> Replace assignment of 0 to pointer with NULL assignment.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_nvmet.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index faa596f9e861..f6ebfe05224c 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -3364,7 +3364,7 @@ lpfc_nvmet_sol_fcp_issue_abort(struct lpfc_hba *phba,
> /* ABTS WQE must go to the same WQ as the WQE to be aborted */
> abts_wqeq->hba_wqidx = ctxp->wqeq->hba_wqidx;
> abts_wqeq->wqe_cmpl = lpfc_nvmet_sol_fcp_abort_cmp;
> - abts_wqeq->iocb_cmpl = 0;
> + abts_wqeq->iocb_cmpl = NULL;
> abts_wqeq->iocb_flag |= LPFC_IO_NVME;
> abts_wqeq->context2 = ctxp;
> abts_wqeq->vport = phba->pport;
> @@ -3499,7 +3499,7 @@ lpfc_nvmet_unsol_ls_issue_abort(struct lpfc_hba *phba,
>
> spin_lock_irqsave(&phba->hbalock, flags);
> abts_wqeq->wqe_cmpl = lpfc_nvmet_xmt_ls_abort_cmp;
> - abts_wqeq->iocb_cmpl = 0;
> + abts_wqeq->iocb_cmpl = NULL;
> abts_wqeq->iocb_flag |= LPFC_IO_NVME_LS;
> rc = lpfc_sli4_issue_wqe(phba, ctxp->hdwq, abts_wqeq);
> spin_unlock_irqrestore(&phba->hbalock, flags);
Thanks
Reviewed-by: James Smart <james.smart@broadcom.com>
-- james
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: lpfc: lpfc_nvmet.c: Fix Use plain integer as NULL pointer
[not found] <20191024030857.GA12097@saurav>
2019-10-24 18:15 ` [PATCH] scsi: lpfc: lpfc_nvmet.c: Fix Use plain integer as NULL pointer James Smart
@ 2019-10-25 1:12 ` Martin K. Petersen
1 sibling, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-10-25 1:12 UTC (permalink / raw)
To: Saurav Girepunje
Cc: james.smart, dick.kennedy, jejb, martin.petersen, linux-scsi,
linux-kernel, saurav.girepunje
Saurav,
> Replace assignment of 0 to pointer with NULL assignment.
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-25 1:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191024030857.GA12097@saurav>
2019-10-24 18:15 ` [PATCH] scsi: lpfc: lpfc_nvmet.c: Fix Use plain integer as NULL pointer James Smart
2019-10-25 1:12 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.