[PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang

[PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang

[Gustavo A. R. Silva]

In preparation to enable -Wimplicit-fallthrough for Clang, fix
a fall-through warning by replacing a /* fallthrough */ comment
with the new pseudo-keyword macro fallthrough;

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
JFYI: We had thousands of these sorts of warnings and now we are down
      to just 22 in linux-next. This is one of those last remaining
      warnings.

 drivers/scsi/NCR5380.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 8aa964cd54df..3baadd068768 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -1816,7 +1816,7 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
 				switch (tmp) {
 				case ABORT:
 					set_host_byte(cmd, DID_ABORT);
-					/* fallthrough */
+					fallthrough;
 				case COMMAND_COMPLETE:
 					/* Accept message by clearing ACK */
 					sink = 1;
-- 
2.27.0

Re: [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang

[Kees Cook]

On Thu, Jun 03, 2021 at 09:27:52PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix
> a fall-through warning by replacing a /* fallthrough */ comment
> with the new pseudo-keyword macro fallthrough;
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Thanks!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

Re: [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang

[Martin K. Petersen]

Gustavo,

> In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> fall-through warning by replacing a /* fallthrough */ comment with the
> new pseudo-keyword macro fallthrough;

Applied to 5.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang

[Martin K. Petersen]

On Thu, 3 Jun 2021 21:27:52 -0500, Gustavo A. R. Silva wrote:

> In preparation to enable -Wimplicit-fallthrough for Clang, fix
> a fall-through warning by replacing a /* fallthrough */ comment
> with the new pseudo-keyword macro fallthrough;

Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: NCR5380: Fix fall-through warning for Clang
      https://git.kernel.org/mkp/scsi/c/61f4f11b48f9

-- 
Martin K. Petersen	Oracle Linux Engineering