* [PATCH] scsi: Fix a comment in function scsi_host_dev_release()
@ 2021-05-10 11:35 chenxiang
2021-05-15 2:50 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: chenxiang @ 2021-05-10 11:35 UTC (permalink / raw)
To: martin.petersen, jejb; +Cc: linux-scsi, bvanassche, linuxarm, Xiang Chen
From: Xiang Chen <chenxiang66@hisilicon.com>
After the patch (3be8828fc507 ("scsi: core: Avoid that ATA error handling
can trigger a kernel hang or oops")), it uses rcu to scsi_cmnd instead
of shost, so modify "shost->rcu" to "scmd->rcu" in a comment.
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
---
drivers/scsi/hosts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 697c09e..ba72bd4 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -317,7 +317,7 @@ static void scsi_host_dev_release(struct device *dev)
scsi_proc_hostdir_rm(shost->hostt);
- /* Wait for functions invoked through call_rcu(&shost->rcu, ...) */
+ /* Wait for functions invoked through call_rcu(&scmd->rcu, ...) */
rcu_barrier();
if (shost->tmf_work_q)
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: Fix a comment in function scsi_host_dev_release()
2021-05-10 11:35 [PATCH] scsi: Fix a comment in function scsi_host_dev_release() chenxiang
@ 2021-05-15 2:50 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-05-15 2:50 UTC (permalink / raw)
To: chenxiang; +Cc: martin.petersen, jejb, linux-scsi, bvanassche, linuxarm
chenxiang,
> After the patch (3be8828fc507 ("scsi: core: Avoid that ATA error
> handling can trigger a kernel hang or oops")), it uses rcu to
> scsi_cmnd instead of shost, so modify "shost->rcu" to "scmd->rcu" in a
> comment.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-15 2:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 11:35 [PATCH] scsi: Fix a comment in function scsi_host_dev_release() chenxiang
2021-05-15 2:50 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.