* [PATCH] scsi: increase max device queue_depth to 4096
@ 2022-04-14 10:36 Sumit Saxena
2022-04-19 3:03 ` Martin K. Petersen
2022-04-26 4:00 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Sumit Saxena @ 2022-04-14 10:36 UTC (permalink / raw)
To: linux-scsi
Cc: martin.petersen, sathya.prakash, kashyap.desai, Sumit Saxena,
Ming Lei, Hannes Reinecke, Bart Van Assche, Sumanesh Samanta
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
Maximum SCSI device queue depth limited to 1024 is not sufficient
for RAID volumes configured behind Broadcom RAID controllers.
For a 16 drives RAID volume with 1024 device QD, per drive
64 IOs(1024/16) can be issued which is not good enough to achieve
performance target.
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Sumanesh Samanta <sumanesh.samanta@broadcom.com>
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
---
drivers/scsi/scsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index 211aace69c22..735b6c862b46 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -200,11 +200,11 @@ void scsi_finish_command(struct scsi_cmnd *cmd)
/*
- * 1024 is big enough for saturating fast SCSI LUNs.
+ * 4096 is big enough for saturating fast SCSI LUNs.
*/
int scsi_device_max_queue_depth(struct scsi_device *sdev)
{
- return min_t(int, sdev->host->can_queue, 1024);
+ return min_t(int, sdev->host->can_queue, 4096);
}
/**
--
2.27.0
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: increase max device queue_depth to 4096
2022-04-14 10:36 [PATCH] scsi: increase max device queue_depth to 4096 Sumit Saxena
@ 2022-04-19 3:03 ` Martin K. Petersen
2022-04-26 4:00 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-04-19 3:03 UTC (permalink / raw)
To: Sumit Saxena
Cc: linux-scsi, martin.petersen, sathya.prakash, kashyap.desai,
Ming Lei, Hannes Reinecke, Bart Van Assche, Sumanesh Samanta
Sumit,
> Maximum SCSI device queue depth limited to 1024 is not sufficient for
> RAID volumes configured behind Broadcom RAID controllers. For a 16
> drives RAID volume with 1024 device QD, per drive 64 IOs(1024/16) can
> be issued which is not good enough to achieve performance target.
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: increase max device queue_depth to 4096
2022-04-14 10:36 [PATCH] scsi: increase max device queue_depth to 4096 Sumit Saxena
2022-04-19 3:03 ` Martin K. Petersen
@ 2022-04-26 4:00 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-04-26 4:00 UTC (permalink / raw)
To: linux-scsi, Sumit Saxena
Cc: Martin K . Petersen, Ming Lei, Bart Van Assche, kashyap.desai,
sathya.prakash, Hannes Reinecke, Sumanesh Samanta
On Thu, 14 Apr 2022 06:36:01 -0400, Sumit Saxena wrote:
> Maximum SCSI device queue depth limited to 1024 is not sufficient
> for RAID volumes configured behind Broadcom RAID controllers.
> For a 16 drives RAID volume with 1024 device QD, per drive
> 64 IOs(1024/16) can be issued which is not good enough to achieve
> performance target.
>
>
> [...]
Applied to 5.19/scsi-queue, thanks!
[1/1] scsi: increase max device queue_depth to 4096
https://git.kernel.org/mkp/scsi/c/f9bdac31cf4b
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-26 4:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14 10:36 [PATCH] scsi: increase max device queue_depth to 4096 Sumit Saxena
2022-04-19 3:03 ` Martin K. Petersen
2022-04-26 4:00 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.