* [PATCH] scsi: target: iscsi: cxgbit: use pr_debug() instead of pr_info()
@ 2018-08-11 15:52 Varun Prakash
2018-08-14 17:07 ` Mike Christie
2018-08-24 2:27 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Varun Prakash @ 2018-08-11 15:52 UTC (permalink / raw)
To: target-devel
DDP programming happens in data path and it can fail because
of lack of resources so use pr_debug() instead of pr_info()
for this case.
Signed-off-by: Varun Prakash <varun@chelsio.com>
---
drivers/target/iscsi/cxgbit/cxgbit_ddp.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
index 768cce0..76a2626 100644
--- a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
+++ b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
@@ -207,8 +207,8 @@ cxgbit_ddp_reserve(struct cxgbit_sock *csk, struct cxgbi_task_tag_info *ttinfo,
ret = dma_map_sg(&ppm->pdev->dev, sgl, sgcnt, DMA_FROM_DEVICE);
sgl->offset = sg_offset;
if (!ret) {
- pr_info("%s: 0x%x, xfer %u, sgl %u dma mapping err.\n",
- __func__, 0, xferlen, sgcnt);
+ pr_debug("%s: 0x%x, xfer %u, sgl %u dma mapping err.\n",
+ __func__, 0, xferlen, sgcnt);
goto rel_ppods;
}
@@ -250,8 +250,8 @@ cxgbit_get_r2t_ttt(struct iscsi_conn *conn, struct iscsi_cmd *cmd,
ret = cxgbit_ddp_reserve(csk, ttinfo, cmd->se_cmd.data_length);
if (ret < 0) {
- pr_info("csk 0x%p, cmd 0x%p, xfer len %u, sgcnt %u no ddp.\n",
- csk, cmd, cmd->se_cmd.data_length, ttinfo->nents);
+ pr_debug("csk 0x%p, cmd 0x%p, xfer len %u, sgcnt %u no ddp.\n",
+ csk, cmd, cmd->se_cmd.data_length, ttinfo->nents);
ttinfo->sgl = NULL;
ttinfo->nents = 0;
--
2.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: target: iscsi: cxgbit: use pr_debug() instead of pr_info()
2018-08-11 15:52 [PATCH] scsi: target: iscsi: cxgbit: use pr_debug() instead of pr_info() Varun Prakash
@ 2018-08-14 17:07 ` Mike Christie
2018-08-24 2:27 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Mike Christie @ 2018-08-14 17:07 UTC (permalink / raw)
To: target-devel
On 08/11/2018 10:40 AM, Varun Prakash wrote:
> DDP programming happens in data path and it can fail because
> of lack of resources so use pr_debug() instead of pr_info()
> for this case.
>
> Signed-off-by: Varun Prakash <varun@chelsio.com>
> ---
> drivers/target/iscsi/cxgbit/cxgbit_ddp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
> index 768cce0..76a2626 100644
> --- a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
> +++ b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
> @@ -207,8 +207,8 @@ cxgbit_ddp_reserve(struct cxgbit_sock *csk, struct cxgbi_task_tag_info *ttinfo,
> ret = dma_map_sg(&ppm->pdev->dev, sgl, sgcnt, DMA_FROM_DEVICE);
> sgl->offset = sg_offset;
> if (!ret) {
> - pr_info("%s: 0x%x, xfer %u, sgl %u dma mapping err.\n",
> - __func__, 0, xferlen, sgcnt);
> + pr_debug("%s: 0x%x, xfer %u, sgl %u dma mapping err.\n",
> + __func__, 0, xferlen, sgcnt);
> goto rel_ppods;
> }
>
> @@ -250,8 +250,8 @@ cxgbit_get_r2t_ttt(struct iscsi_conn *conn, struct iscsi_cmd *cmd,
>
> ret = cxgbit_ddp_reserve(csk, ttinfo, cmd->se_cmd.data_length);
> if (ret < 0) {
> - pr_info("csk 0x%p, cmd 0x%p, xfer len %u, sgcnt %u no ddp.\n",
> - csk, cmd, cmd->se_cmd.data_length, ttinfo->nents);
> + pr_debug("csk 0x%p, cmd 0x%p, xfer len %u, sgcnt %u no ddp.\n",
> + csk, cmd, cmd->se_cmd.data_length, ttinfo->nents);
>
> ttinfo->sgl = NULL;
> ttinfo->nents = 0;
>
Reviewed-by: Mike Christie <mchristi@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: target: iscsi: cxgbit: use pr_debug() instead of pr_info()
2018-08-11 15:52 [PATCH] scsi: target: iscsi: cxgbit: use pr_debug() instead of pr_info() Varun Prakash
2018-08-14 17:07 ` Mike Christie
@ 2018-08-24 2:27 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2018-08-24 2:27 UTC (permalink / raw)
To: target-devel
Varun,
> DDP programming happens in data path and it can fail because of lack
> of resources so use pr_debug() instead of pr_info() for this case.
Applied to 4.19/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-24 2:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-11 15:52 [PATCH] scsi: target: iscsi: cxgbit: use pr_debug() instead of pr_info() Varun Prakash
2018-08-14 17:07 ` Mike Christie
2018-08-24 2:27 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.