All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] qedi: Drop cqe response during connection recovery
@ 2018-01-19  6:52 Manish Rangankar
  2018-01-23  0:24 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Manish Rangankar @ 2018-01-19  6:52 UTC (permalink / raw)
  To: martin.petersen, lduncan, cleech; +Cc: linux-scsi, QLogic-Storage-Upstream

We get stuck in the loop when firmware sends a cqe response
during connection recovery.

Signed-off-by: Manish Rangankar <manish.rangankar@cavium.com>
---
 drivers/scsi/qedi/qedi_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index cccc34a..8808f0d 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -998,7 +998,9 @@ static bool qedi_process_completions(struct qedi_fastpath *fp)
 
 		ret = qedi_queue_cqe(qedi, cqe, fp->sb_id, p);
 		if (ret)
-			continue;
+			QEDI_WARN(&qedi->dbg_ctx,
+				  "Dropping CQE 0x%x for cid=0x%x.\n",
+				  que->cq_cons_idx, cqe->cqe_common.conn_id);
 
 		que->cq_cons_idx++;
 		if (que->cq_cons_idx == QEDI_CQ_SIZE)
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] qedi: Drop cqe response during connection recovery
  2018-01-19  6:52 [PATCH] qedi: Drop cqe response during connection recovery Manish Rangankar
@ 2018-01-23  0:24 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2018-01-23  0:24 UTC (permalink / raw)
  To: Manish Rangankar
  Cc: martin.petersen, lduncan, cleech, linux-scsi, QLogic-Storage-Upstream


Manish,

> We get stuck in the loop when firmware sends a cqe response
> during connection recovery.

Applied to 4.16/scsi-queue. Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-23  0:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-19  6:52 [PATCH] qedi: Drop cqe response during connection recovery Manish Rangankar
2018-01-23  0:24 ` Martin K. Petersen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.