All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] scsi: qedi: fix build, depends on UIO
@ 2016-12-20 16:43 Randy Dunlap
  2016-12-20 22:49 ` Martin K. Petersen
  2016-12-21  7:35 ` Christoph Hellwig
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2016-12-20 16:43 UTC (permalink / raw)
  To: linux-scsi, LKML
  Cc: QLogic-Storage-Upstream, James E.J. Bottomley, Martin K. Petersen

From: Randy Dunlap <rdunlap@infradead.org>

Fix build of SCSI qedi driver. It uses uio interfaces so it
should depend on UIO.

ERROR: "uio_unregister_device" [drivers/scsi/qedi/qedi.ko] undefined!
ERROR: "uio_event_notify" [drivers/scsi/qedi/qedi.ko] undefined!
ERROR: "__uio_register_device" [drivers/scsi/qedi/qedi.ko] undefined!

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: QLogic-Storage-Upstream@cavium.com
---
 drivers/scsi/qedi/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20161220.orig/drivers/scsi/qedi/Kconfig
+++ linux-next-20161220/drivers/scsi/qedi/Kconfig
@@ -1,6 +1,6 @@
 config QEDI
 	tristate "QLogic QEDI 25/40/100Gb iSCSI Initiator Driver Support"
-	depends on PCI && SCSI
+	depends on PCI && SCSI && UIO
 	depends on QED
 	select SCSI_ISCSI_ATTRS
 	select QED_LL2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] scsi: qedi: fix build, depends on UIO
  2016-12-20 16:43 [PATCH -next] scsi: qedi: fix build, depends on UIO Randy Dunlap
@ 2016-12-20 22:49 ` Martin K. Petersen
  2016-12-21  7:35 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-12-20 22:49 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-scsi, LKML, QLogic-Storage-Upstream, James E.J. Bottomley,
	Martin K. Petersen

>>>>> "Randy" == Randy Dunlap <rdunlap@infradead.org> writes:

Randy> From: Randy Dunlap <rdunlap@infradead.org> Fix build of SCSI qedi
Randy> driver. It uses uio interfaces so it should depend on UIO.

Applied to 4.10/scsi-fixes.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] scsi: qedi: fix build, depends on UIO
  2016-12-20 16:43 [PATCH -next] scsi: qedi: fix build, depends on UIO Randy Dunlap
  2016-12-20 22:49 ` Martin K. Petersen
@ 2016-12-21  7:35 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2016-12-21  7:35 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-scsi, LKML, QLogic-Storage-Upstream, James E.J. Bottomley,
	Martin K. Petersen

On Tue, Dec 20, 2016 at 08:43:30AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build of SCSI qedi driver. It uses uio interfaces so it
> should depend on UIO.
> 
> ERROR: "uio_unregister_device" [drivers/scsi/qedi/qedi.ko] undefined!
> ERROR: "uio_event_notify" [drivers/scsi/qedi/qedi.ko] undefined!
> ERROR: "__uio_register_device" [drivers/scsi/qedi/qedi.ko] undefined!

Why is it hiding an uio driver in an iscsi offload driver?

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-12-21  7:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-20 16:43 [PATCH -next] scsi: qedi: fix build, depends on UIO Randy Dunlap
2016-12-20 22:49 ` Martin K. Petersen
2016-12-21  7:35 ` Christoph Hellwig

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.