* [PATCH v2] megaraid: Downgrade two success messages to info
@ 2016-05-03 17:24 Andy Lutomirski
2016-05-04 6:50 ` Hannes Reinecke
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andy Lutomirski @ 2016-05-03 17:24 UTC (permalink / raw)
To: Kashyap Desai, Sumit Saxena, Uday Lingala
Cc: megaraidlinux.pdl, linux-scsi, Andy Lutomirski
I actually read the error messages in my logs, and successful
initialization is not an error.
Arguably these log lines could be deleted entirely.
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
Changes from v2: Remove hunk that didn't belong
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index e6ebc7ae2df1..d020919e8085 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5152,7 +5152,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
instance->instancet->enable_intr(instance);
- dev_err(&instance->pdev->dev, "INIT adapter done\n");
+ dev_info(&instance->pdev->dev, "INIT adapter done\n");
megasas_setup_jbod_map(instance);
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 98a848bdfdc2..9375805670a9 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -851,7 +851,7 @@ megasas_ioc_init_fusion(struct megasas_instance *instance)
ret = 1;
goto fail_fw_init;
}
- dev_err(&instance->pdev->dev, "Init cmd success\n");
+ dev_info(&instance->pdev->dev, "Init cmd success\n");
ret = 0;
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] megaraid: Downgrade two success messages to info
2016-05-03 17:24 [PATCH v2] megaraid: Downgrade two success messages to info Andy Lutomirski
@ 2016-05-04 6:50 ` Hannes Reinecke
2016-05-04 6:59 ` Sumit Saxena
2016-05-06 1:05 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2016-05-04 6:50 UTC (permalink / raw)
To: Andy Lutomirski, Kashyap Desai, Sumit Saxena, Uday Lingala
Cc: megaraidlinux.pdl, linux-scsi
On 05/03/2016 07:24 PM, Andy Lutomirski wrote:
> I actually read the error messages in my logs, and successful
> initialization is not an error.
>
> Arguably these log lines could be deleted entirely.
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
>
> Changes from v2: Remove hunk that didn't belong
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2] megaraid: Downgrade two success messages to info
2016-05-03 17:24 [PATCH v2] megaraid: Downgrade two success messages to info Andy Lutomirski
2016-05-04 6:50 ` Hannes Reinecke
@ 2016-05-04 6:59 ` Sumit Saxena
2016-05-06 1:05 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Sumit Saxena @ 2016-05-04 6:59 UTC (permalink / raw)
To: Andy Lutomirski, Kashyap Desai, Sumit Saxena, Uday Lingala
Cc: megaraidlinux.pdl, linux-scsi
> -----Original Message-----
> From: Andy Lutomirski [mailto:luto@kernel.org]
> Sent: Tuesday, May 03, 2016 10:55 PM
> To: Kashyap Desai; Sumit Saxena; Uday Lingala
> Cc: megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org; Andy
> Lutomirski
> Subject: [PATCH v2] megaraid: Downgrade two success messages to info
>
> I actually read the error messages in my logs, and successful
initialization is not
> an error.
>
> Arguably these log lines could be deleted entirely.
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
>
> Changes from v2: Remove hunk that didn't belong
>
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index e6ebc7ae2df1..d020919e8085 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5152,7 +5152,7 @@ static int megasas_init_fw(struct megasas_instance
> *instance)
>
> instance->instancet->enable_intr(instance);
>
> - dev_err(&instance->pdev->dev, "INIT adapter done\n");
> + dev_info(&instance->pdev->dev, "INIT adapter done\n");
>
> megasas_setup_jbod_map(instance);
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 98a848bdfdc2..9375805670a9 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -851,7 +851,7 @@ megasas_ioc_init_fusion(struct megasas_instance
> *instance)
> ret = 1;
> goto fail_fw_init;
> }
> - dev_err(&instance->pdev->dev, "Init cmd success\n");
> + dev_info(&instance->pdev->dev, "Init cmd success\n");
>
> ret = 0;
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
>
> --
> 2.5.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] megaraid: Downgrade two success messages to info
2016-05-03 17:24 [PATCH v2] megaraid: Downgrade two success messages to info Andy Lutomirski
2016-05-04 6:50 ` Hannes Reinecke
2016-05-04 6:59 ` Sumit Saxena
@ 2016-05-06 1:05 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2016-05-06 1:05 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Kashyap Desai, Sumit Saxena, Uday Lingala, megaraidlinux.pdl, linux-scsi
>>>>> "Andy" == Andy Lutomirski <luto@kernel.org> writes:
Andy> I actually read the error messages in my logs, and successful
Andy> initialization is not an error.
Andy> Arguably these log lines could be deleted entirely.
Applied to 4.7/scsi-queue.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-06 1:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-03 17:24 [PATCH v2] megaraid: Downgrade two success messages to info Andy Lutomirski
2016-05-04 6:50 ` Hannes Reinecke
2016-05-04 6:59 ` Sumit Saxena
2016-05-06 1:05 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.