* [PATCH] bfa: do not dereference port before it is null checked
@ 2016-08-30 16:36 Colin King
2016-08-31 12:05 ` Johannes Thumshirn
2016-09-02 10:10 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2016-08-30 16:36 UTC (permalink / raw)
To: Anil Gurumurthy, Sudarsana Kalluru, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
port is deferenced before it is null sanity checked, hence
we potentially have a null pointer dereference bug. Instead,
initialise trl_enabled from port->fcs->bfa after we are sure
port is not null.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/bfa/bfa_fcs_lport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c
index 7733ad5..bdf39e7 100644
--- a/drivers/scsi/bfa/bfa_fcs_lport.c
+++ b/drivers/scsi/bfa/bfa_fcs_lport.c
@@ -5827,13 +5827,13 @@ bfa_fcs_lport_get_rport_max_speed(bfa_fcs_lport_t *port)
bfa_port_speed_t max_speed = 0;
struct bfa_port_attr_s port_attr;
bfa_port_speed_t port_speed, rport_speed;
- bfa_boolean_t trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
-
+ bfa_boolean_t trl_enabled;
if (port == NULL)
return 0;
fcs = port->fcs;
+ trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
/* Get Physical port's current speed */
bfa_fcport_get_attr(port->fcs->bfa, &port_attr);
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bfa: do not dereference port before it is null checked
2016-08-30 16:36 [PATCH] bfa: do not dereference port before it is null checked Colin King
@ 2016-08-31 12:05 ` Johannes Thumshirn
2016-09-02 10:10 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2016-08-31 12:05 UTC (permalink / raw)
To: Colin King
Cc: Anil Gurumurthy, Sudarsana Kalluru, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, linux-kernel
On Tue, Aug 30, 2016 at 05:36:16PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> port is deferenced before it is null sanity checked, hence
> we potentially have a null pointer dereference bug. Instead,
> initialise trl_enabled from port->fcs->bfa after we are sure
> port is not null.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bfa: do not dereference port before it is null checked
2016-08-30 16:36 [PATCH] bfa: do not dereference port before it is null checked Colin King
2016-08-31 12:05 ` Johannes Thumshirn
@ 2016-09-02 10:10 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-09-02 10:10 UTC (permalink / raw)
To: Colin King
Cc: Anil Gurumurthy, Sudarsana Kalluru, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, linux-kernel
>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:
Colin> port is deferenced before it is null sanity checked, hence we
Colin> potentially have a null pointer dereference bug. Instead,
Colin> initialise trl_enabled from port->fcs->bfa after we are sure port
Colin> is not null.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-02 10:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-30 16:36 [PATCH] bfa: do not dereference port before it is null checked Colin King
2016-08-31 12:05 ` Johannes Thumshirn
2016-09-02 10:10 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.