All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sd: Unmap discard alignment needs to be converted to bytes
@ 2011-05-18  4:31 Martin K. Petersen
  0 siblings, 0 replies; only message in thread
From: Martin K. Petersen @ 2011-05-18  4:31 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-scsi


The block layer discard alignment is reported in bytes, not in units of
the logical block size.

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index bd0806e..1c69c14 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -490,7 +490,8 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode)
 	unsigned int max_blocks = 0;
 
 	q->limits.discard_zeroes_data = sdkp->lbprz;
-	q->limits.discard_alignment = sdkp->unmap_alignment;
+	q->limits.discard_alignment = sdkp->unmap_alignment *
+		logical_block_size;
 	q->limits.discard_granularity =
 		max(sdkp->physical_block_size,
 		    sdkp->unmap_granularity * logical_block_size);

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-05-18  4:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-18  4:31 [PATCH] sd: Unmap discard alignment needs to be converted to bytes Martin K. Petersen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.