* [PATCH] scsi: isci: make isci_host_attrs static
@ 2020-09-12 3:37 Jason Yan
2020-09-16 1:28 ` Martin K. Petersen
2020-09-22 3:56 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-09-12 3:37 UTC (permalink / raw)
To: intel-linux-scu, artur.paszkiewicz, jejb, martin.petersen, arnd,
linux-scsi
Cc: Jason Yan, Hulk Robot
This eliminates the following sparse warning:
drivers/scsi/isci/init.c:145:25: warning: symbol 'isci_host_attrs' was
not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/isci/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
index 085e285f427d..93bc9019667f 100644
--- a/drivers/scsi/isci/init.c
+++ b/drivers/scsi/isci/init.c
@@ -142,7 +142,7 @@ static ssize_t isci_show_id(struct device *dev, struct device_attribute *attr, c
static DEVICE_ATTR(isci_id, S_IRUGO, isci_show_id, NULL);
-struct device_attribute *isci_host_attrs[] = {
+static struct device_attribute *isci_host_attrs[] = {
&dev_attr_isci_id,
NULL
};
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: isci: make isci_host_attrs static
2020-09-12 3:37 [PATCH] scsi: isci: make isci_host_attrs static Jason Yan
@ 2020-09-16 1:28 ` Martin K. Petersen
2020-09-22 3:56 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-09-16 1:28 UTC (permalink / raw)
To: Jason Yan
Cc: intel-linux-scu, artur.paszkiewicz, jejb, martin.petersen, arnd,
linux-scsi, Hulk Robot
Jason,
> This eliminates the following sparse warning:
>
> drivers/scsi/isci/init.c:145:25: warning: symbol 'isci_host_attrs' was
> not declared. Should it be static?
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: isci: make isci_host_attrs static
2020-09-12 3:37 [PATCH] scsi: isci: make isci_host_attrs static Jason Yan
2020-09-16 1:28 ` Martin K. Petersen
@ 2020-09-22 3:56 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-09-22 3:56 UTC (permalink / raw)
To: linux-scsi, intel-linux-scu, Jason Yan, artur.paszkiewicz, arnd, jejb
Cc: Martin K . Petersen, Hulk Robot
On Sat, 12 Sep 2020 11:37:41 +0800, Jason Yan wrote:
> This eliminates the following sparse warning:
>
> drivers/scsi/isci/init.c:145:25: warning: symbol 'isci_host_attrs' was
> not declared. Should it be static?
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: isci: Make isci_host_attrs static
https://git.kernel.org/mkp/scsi/c/7867c549d574
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-22 3:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-12 3:37 [PATCH] scsi: isci: make isci_host_attrs static Jason Yan
2020-09-16 1:28 ` Martin K. Petersen
2020-09-22 3:56 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.