All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] qedi: Remove unwanted warnings.
@ 2017-06-15  7:10 Manish Rangankar
  2017-06-15  7:10 ` [PATCH 1/2] qedi: Remove WARN_ON for untracked cleanup Manish Rangankar
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Manish Rangankar @ 2017-06-15  7:10 UTC (permalink / raw)
  To: martin.petersen, lduncan, cleech; +Cc: linux-scsi, QLogic-Storage-Upstream

Martin,

Please consider below patches for next 'scsi-fixes' submission.

Thanks,
Manish

Manish Rangankar (2):
  qedi: Remove WARN_ON for untracked cleanup.
  qedi: Remove WARN_ON from clear task context.

 drivers/scsi/qedi/qedi_fw.c   | 1 -
 drivers/scsi/qedi/qedi_main.c | 4 +---
 2 files changed, 1 insertion(+), 4 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 1/2] qedi: Remove WARN_ON for untracked cleanup.
  2017-06-15  7:10 [PATCH 0/2] qedi: Remove unwanted warnings Manish Rangankar
@ 2017-06-15  7:10 ` Manish Rangankar
  2017-06-16 18:45   ` Lee Duncan
  2017-06-15  7:10 ` [PATCH 2/2] qedi: Remove WARN_ON from clear task context Manish Rangankar
  2017-06-20  1:54 ` [PATCH 0/2] qedi: Remove unwanted warnings Martin K. Petersen
  2 siblings, 1 reply; 6+ messages in thread
From: Manish Rangankar @ 2017-06-15  7:10 UTC (permalink / raw)
  To: martin.petersen, lduncan, cleech; +Cc: linux-scsi, QLogic-Storage-Upstream

Signed-off-by: Manish Rangankar <manish.rangankar@cavium.com>
---
 drivers/scsi/qedi/qedi_fw.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c
index 8bc7ee1..507512c 100644
--- a/drivers/scsi/qedi/qedi_fw.c
+++ b/drivers/scsi/qedi/qedi_fw.c
@@ -870,7 +870,6 @@ static void qedi_process_cmd_cleanup_resp(struct qedi_ctx *qedi,
 		QEDI_ERR(&qedi->dbg_ctx,
 			 "Delayed or untracked cleanup response, itt=0x%x, tid=0x%x, cid=0x%x, task=%p\n",
 			 protoitt, cqe->itid, qedi_conn->iscsi_conn_id, task);
-		WARN_ON(1);
 	}
 }
 
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] qedi: Remove WARN_ON from clear task context.
  2017-06-15  7:10 [PATCH 0/2] qedi: Remove unwanted warnings Manish Rangankar
  2017-06-15  7:10 ` [PATCH 1/2] qedi: Remove WARN_ON for untracked cleanup Manish Rangankar
@ 2017-06-15  7:10 ` Manish Rangankar
  2017-06-16 18:46   ` Lee Duncan
  2017-06-20  1:54 ` [PATCH 0/2] qedi: Remove unwanted warnings Martin K. Petersen
  2 siblings, 1 reply; 6+ messages in thread
From: Manish Rangankar @ 2017-06-15  7:10 UTC (permalink / raw)
  To: martin.petersen, lduncan, cleech; +Cc: linux-scsi, QLogic-Storage-Upstream

Signed-off-by: Manish Rangankar <manish.rangankar@cavium.com>
---
 drivers/scsi/qedi/qedi_main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 09a2946..879d3b7 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -1499,11 +1499,9 @@ int qedi_get_task_idx(struct qedi_ctx *qedi)
 
 void qedi_clear_task_idx(struct qedi_ctx *qedi, int idx)
 {
-	if (!test_and_clear_bit(idx, qedi->task_idx_map)) {
+	if (!test_and_clear_bit(idx, qedi->task_idx_map))
 		QEDI_ERR(&qedi->dbg_ctx,
 			 "FW task context, already cleared, tid=0x%x\n", idx);
-		WARN_ON(1);
-	}
 }
 
 void qedi_update_itt_map(struct qedi_ctx *qedi, u32 tid, u32 proto_itt,
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] qedi: Remove WARN_ON for untracked cleanup.
  2017-06-15  7:10 ` [PATCH 1/2] qedi: Remove WARN_ON for untracked cleanup Manish Rangankar
@ 2017-06-16 18:45   ` Lee Duncan
  0 siblings, 0 replies; 6+ messages in thread
From: Lee Duncan @ 2017-06-16 18:45 UTC (permalink / raw)
  To: Manish Rangankar, martin.petersen, cleech
  Cc: linux-scsi, QLogic-Storage-Upstream

On 06/15/2017 12:10 AM, Manish Rangankar wrote:
> Signed-off-by: Manish Rangankar <manish.rangankar@cavium.com>
> ---
>  drivers/scsi/qedi/qedi_fw.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c
> index 8bc7ee1..507512c 100644
> --- a/drivers/scsi/qedi/qedi_fw.c
> +++ b/drivers/scsi/qedi/qedi_fw.c
> @@ -870,7 +870,6 @@ static void qedi_process_cmd_cleanup_resp(struct qedi_ctx *qedi,
>  		QEDI_ERR(&qedi->dbg_ctx,
>  			 "Delayed or untracked cleanup response, itt=0x%x, tid=0x%x, cid=0x%x, task=%p\n",
>  			 protoitt, cqe->itid, qedi_conn->iscsi_conn_id, task);
> -		WARN_ON(1);
>  	}
>  }
>  
> 

Reviewed-by: Lee Duncan <lduncan@suse.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] qedi: Remove WARN_ON from clear task context.
  2017-06-15  7:10 ` [PATCH 2/2] qedi: Remove WARN_ON from clear task context Manish Rangankar
@ 2017-06-16 18:46   ` Lee Duncan
  0 siblings, 0 replies; 6+ messages in thread
From: Lee Duncan @ 2017-06-16 18:46 UTC (permalink / raw)
  To: Manish Rangankar, martin.petersen, cleech
  Cc: linux-scsi, QLogic-Storage-Upstream

On 06/15/2017 12:10 AM, Manish Rangankar wrote:
> Signed-off-by: Manish Rangankar <manish.rangankar@cavium.com>
> ---
>  drivers/scsi/qedi/qedi_main.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index 09a2946..879d3b7 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1499,11 +1499,9 @@ int qedi_get_task_idx(struct qedi_ctx *qedi)
>  
>  void qedi_clear_task_idx(struct qedi_ctx *qedi, int idx)
>  {
> -	if (!test_and_clear_bit(idx, qedi->task_idx_map)) {
> +	if (!test_and_clear_bit(idx, qedi->task_idx_map))
>  		QEDI_ERR(&qedi->dbg_ctx,
>  			 "FW task context, already cleared, tid=0x%x\n", idx);
> -		WARN_ON(1);
> -	}
>  }
>  
>  void qedi_update_itt_map(struct qedi_ctx *qedi, u32 tid, u32 proto_itt,
> 

Reviewed-by: Lee Duncan <lduncan@suse.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] qedi: Remove unwanted warnings.
  2017-06-15  7:10 [PATCH 0/2] qedi: Remove unwanted warnings Manish Rangankar
  2017-06-15  7:10 ` [PATCH 1/2] qedi: Remove WARN_ON for untracked cleanup Manish Rangankar
  2017-06-15  7:10 ` [PATCH 2/2] qedi: Remove WARN_ON from clear task context Manish Rangankar
@ 2017-06-20  1:54 ` Martin K. Petersen
  2 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2017-06-20  1:54 UTC (permalink / raw)
  To: Manish Rangankar
  Cc: martin.petersen, lduncan, cleech, linux-scsi, QLogic-Storage-Upstream


Manish,

> Please consider below patches for next 'scsi-fixes' submission.

Applied to 4.12/scsi-fixes, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-20  1:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-15  7:10 [PATCH 0/2] qedi: Remove unwanted warnings Manish Rangankar
2017-06-15  7:10 ` [PATCH 1/2] qedi: Remove WARN_ON for untracked cleanup Manish Rangankar
2017-06-16 18:45   ` Lee Duncan
2017-06-15  7:10 ` [PATCH 2/2] qedi: Remove WARN_ON from clear task context Manish Rangankar
2017-06-16 18:46   ` Lee Duncan
2017-06-20  1:54 ` [PATCH 0/2] qedi: Remove unwanted warnings Martin K. Petersen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.