* [PATCH] scsi: qedf: properly update arguments position in function call
@ 2017-05-03 19:17 Gustavo A. R. Silva
2017-05-04 15:06 ` Chad Dupuis
2017-05-09 1:49 ` Martin K. Petersen
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2017-05-03 19:17 UTC (permalink / raw)
To: QLogic-Storage-Upstream, James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel, Gustavo A. R. Silva
Properly update the position of the arguments in function call.
Addresses-Coverity-ID: 1402010
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/scsi/qedf/qedf_els.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qedf/qedf_els.c b/drivers/scsi/qedf/qedf_els.c
index 59f3e5c..107ed2b 100644
--- a/drivers/scsi/qedf/qedf_els.c
+++ b/drivers/scsi/qedf/qedf_els.c
@@ -106,7 +106,7 @@ static int qedf_initiate_els(struct qedf_rport *fcport, unsigned int op,
did = fcport->rdata->ids.port_id;
sid = fcport->sid;
- __fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, sid, did,
+ __fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, did, sid,
FC_TYPE_ELS, FC_FC_FIRST_SEQ | FC_FC_END_SEQ |
FC_FC_SEQ_INIT, 0);
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: qedf: properly update arguments position in function call
2017-05-03 19:17 [PATCH] scsi: qedf: properly update arguments position in function call Gustavo A. R. Silva
@ 2017-05-04 15:06 ` Chad Dupuis
2017-05-09 1:49 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Chad Dupuis @ 2017-05-04 15:06 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel
On Wed, 3 May 2017, 3:17pm, Gustavo A. R. Silva wrote:
> Properly update the position of the arguments in function call.
>
> Addresses-Coverity-ID: 1402010
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/scsi/qedf/qedf_els.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qedf/qedf_els.c b/drivers/scsi/qedf/qedf_els.c
> index 59f3e5c..107ed2b 100644
> --- a/drivers/scsi/qedf/qedf_els.c
> +++ b/drivers/scsi/qedf/qedf_els.c
> @@ -106,7 +106,7 @@ static int qedf_initiate_els(struct qedf_rport *fcport, unsigned int op,
> did = fcport->rdata->ids.port_id;
> sid = fcport->sid;
>
> - __fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, sid, did,
> + __fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, did, sid,
> FC_TYPE_ELS, FC_FC_FIRST_SEQ | FC_FC_END_SEQ |
> FC_FC_SEQ_INIT, 0);
>
>
Thanks.
Acked-by: Chad Dupuis <chad.dupuis@cavium.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: qedf: properly update arguments position in function call
2017-05-03 19:17 [PATCH] scsi: qedf: properly update arguments position in function call Gustavo A. R. Silva
2017-05-04 15:06 ` Chad Dupuis
@ 2017-05-09 1:49 ` Martin K. Petersen
2017-05-09 3:06 ` Gustavo A. R. Silva
1 sibling, 1 reply; 4+ messages in thread
From: Martin K. Petersen @ 2017-05-09 1:49 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel
Gustavo A.,
> Properly update the position of the arguments in function call.
Applied to 4.12/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: qedf: properly update arguments position in function call
2017-05-09 1:49 ` Martin K. Petersen
@ 2017-05-09 3:06 ` Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2017-05-09 3:06 UTC (permalink / raw)
To: Martin K. Petersen
Cc: QLogic-Storage-Upstream, James E.J. Bottomley, linux-scsi, linux-kernel
Hi Martin,
Quoting "Martin K. Petersen" <martin.petersen@oracle.com>:
> Gustavo A.,
>
>> Properly update the position of the arguments in function call.
>
> Applied to 4.12/scsi-fixes, thank you!
>
Awesome, glad to help. :)
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-09 3:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-03 19:17 [PATCH] scsi: qedf: properly update arguments position in function call Gustavo A. R. Silva
2017-05-04 15:06 ` Chad Dupuis
2017-05-09 1:49 ` Martin K. Petersen
2017-05-09 3:06 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.