From: "Måns Rullgård" <mans@mansr.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, slash.tmp@free.fr
Subject: Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller
Date: Tue, 27 Oct 2015 12:40:42 +0000 [thread overview]
Message-ID: <yw1x8u6oeb79.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <20151027150209.043946d4@samsung9> (Stephen Hemminger's message of "Tue, 27 Oct 2015 15:02:09 +0900")
Stephen Hemminger <stephen@networkplumber.org> writes:
>> + .get_settings = nb8800_get_settings,
>> + .set_settings = nb8800_set_settings,
>> + .nway_reset = nb8800_nway_reset,
>> + .get_link = ethtool_op_get_link,
>> +};
>> +
>
> Since you are implementing ethtool please add a driver
> info function.
I don't know what I'd set there that the fallback code doesn't.
--
Måns Rullgård
mans@mansr.com
next prev parent reply other threads:[~2015-10-27 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 21:34 [PATCH v3 1/2] devicetree: add binding for Aurora VLSI NB8800 Ethernet controller Mans Rullgard
2015-10-26 21:34 ` [PATCH v3 2/2] net: ethernet: add driver " Mans Rullgard
2015-10-27 6:02 ` Stephen Hemminger
2015-10-27 12:40 ` Måns Rullgård [this message]
2015-10-26 21:40 ` [PATCH v3 1/2] devicetree: add binding " Måns Rullgård
2015-11-12 14:44 ` Rob Herring
2015-11-12 14:44 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1x8u6oeb79.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=slash.tmp@free.fr \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.