Re: [PATCH -next 12/15] thermal: tango: use devm_platform_ioremap_resource() to simplify code

From: "Måns Rullgård" <mans@mansr.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <miquel.raynal@bootlin.com>, <rui.zhang@intel.com>,
	<edubezval@gmail.com>, <daniel.lezcano@linaro.org>,
	<amit.kucheria@verdurent.com>, <eric@anholt.net>,
	<wahrenst@gmx.net>, <f.fainelli@gmail.com>, <rjui@broadcom.com>,
	<sbranden@broadcom.com>, <mmayer@broadcom.com>,
	<computersforpeace@gmail.com>, <gregory.0xf0@gmail.com>,
	<matthias.bgg@gmail.com>, <agross@kernel.org>, <heiko@sntech.de>,
	<mcoquelin.stm32@gmail.com>, <alexandre.torgue@st.com>,
	<marc.w.gonzalez@free.fr>, <talel@amazon.com>,
	<jun.nie@linaro.org>, <shawnguo@kernel.org>,
	<phil@raspberrypi.org>, <gregkh@linuxfoundation.org>,
	<david.hernandezsanchez@st.com>, <horms+renesas@verge.net.au>,
	<wsa+renesas@sang-engineering.com>,
	<bcm-kernel-feedback-list@broadcom.com>,
	<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-rpi-kernel@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-arm-msm@vger.kernel.org>,
	<linux-rockchip@lists.infradead.org>,
	<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH -next 12/15] thermal: tango: use devm_platform_ioremap_resource() to simplify code
Date: Thu, 05 Sep 2019 12:06:54 +0100	[thread overview]
Message-ID: <yw1xmufj6lyp.fsf@mansr.com> (raw)
In-Reply-To: <20190904122939.23780-13-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Wed, 4 Sep 2019 20:29:36 +0800")

YueHaibing <yuehaibing@huawei.com> writes:

> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Mans Rullgard <mans@mansr.com>

> ---
>  drivers/thermal/tango_thermal.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/tango_thermal.c b/drivers/thermal/tango_thermal.c
> index 304b461..f44441b 100644
> --- a/drivers/thermal/tango_thermal.c
> +++ b/drivers/thermal/tango_thermal.c
> @@ -73,7 +73,6 @@ static void tango_thermal_init(struct tango_thermal_priv *priv)
>
>  static int tango_thermal_probe(struct platform_device *pdev)
>  {
> -	struct resource *res;
>  	struct tango_thermal_priv *priv;
>  	struct thermal_zone_device *tzdev;
>
> @@ -81,8 +80,7 @@ static int tango_thermal_probe(struct platform_device *pdev)
>  	if (!priv)
>  		return -ENOMEM;
>
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	priv->base = devm_ioremap_resource(&pdev->dev, res);
> +	priv->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(priv->base))
>  		return PTR_ERR(priv->base);
>
> -- 
> 2.7.4
>

-- 
Måns Rullgård