Re: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check

From: Mikulas Patocka <mikulas@twibright.com>
To: Yaowei Bai <bywxiaobai@163.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check
Date: Tue, 29 Sep 2015 17:03:24 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1509291702190.7735@leontynka> (raw)
In-Reply-To: <1443449479-5379-1-git-send-email-bywxiaobai@163.com>

Hi

I suppose that you should remove the function new_valid_dev at all.

Mikulas

On Mon, 28 Sep 2015, Yaowei Bai wrote:

> As new_valid_dev always returns 1, so !new_valid_dev check is not
> needed, remove it.
> 
> Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
> ---
>  fs/hpfs/namei.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c
> index 9e92c9c..ae4d5a1 100644
> --- a/fs/hpfs/namei.c
> +++ b/fs/hpfs/namei.c
> @@ -227,8 +227,6 @@ static int hpfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, de
>  	int err;
>  	if ((err = hpfs_chk_name(name, &len))) return err==-ENOENT ? -EINVAL : err;
>  	if (hpfs_sb(dir->i_sb)->sb_eas < 2) return -EPERM;
> -	if (!new_valid_dev(rdev))
> -		return -EINVAL;
>  	hpfs_lock(dir->i_sb);
>  	err = -ENOSPC;
>  	fnode = hpfs_alloc_fnode(dir->i_sb, hpfs_i(dir)->i_dno, &fno, &bh);
> -- 
> 1.9.1
> 
> 
> 