From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
David Vrabel <david.vrabel@citrix.com>,
Andrew Jones <drjones@redhat.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
<linux-arm-kernel@lists.infradead.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<xen-devel@lists.xensource.com>, <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v2] xen kconfig: don't "select INPUT_XEN_KBDDEV_FRONTEND"
Date: Tue, 16 Feb 2016 16:55:42 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602161655350.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <2479546.WgivMO2bp2@wuerfel>
On Tue, 16 Feb 2016, Arnd Bergmann wrote:
> The Xen framebuffer driver selects the xen keyboard driver, so the latter
> will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT
> is a loadable module, this configuration cannot work. On mainline kernels,
> the symbol will be enabled but not used, while in combination with
> a patch I have to detect such useless configurations, we get the
> expected link failure:
>
> drivers/input/built-in.o: In function `xenkbd_remove':
> xen-kbdfront.c:(.text+0x2f0): undefined reference to `input_unregister_device'
> xen-kbdfront.c:(.text+0x30e): undefined reference to `input_unregister_device'
>
> This removes the extra "select", as it just causes more trouble than
> it helps. In theory, some defconfig file might break if it has
> XEN_FBDEV_FRONTEND in it but not INPUT_XEN_KBDDEV_FRONTEND. The Kconfig
> fragment we ship in the kernel (kernel/configs/xen.config) however
> already enables both, and anyone using an old .config file would
> keep having both enabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Suggested-by: David Vrabel <david.vrabel@citrix.com>
> Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND")
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 8ea45a5cd806..d889ef2048df 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -2246,7 +2246,6 @@ config XEN_FBDEV_FRONTEND
> select FB_SYS_IMAGEBLIT
> select FB_SYS_FOPS
> select FB_DEFERRED_IO
> - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
> select XEN_XENBUS_FRONTEND
> default y
> help
>
WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] xen kconfig: don't "select INPUT_XEN_KBDDEV_FRONTEND"
Date: Tue, 16 Feb 2016 16:55:42 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602161655350.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <2479546.WgivMO2bp2@wuerfel>
On Tue, 16 Feb 2016, Arnd Bergmann wrote:
> The Xen framebuffer driver selects the xen keyboard driver, so the latter
> will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT
> is a loadable module, this configuration cannot work. On mainline kernels,
> the symbol will be enabled but not used, while in combination with
> a patch I have to detect such useless configurations, we get the
> expected link failure:
>
> drivers/input/built-in.o: In function `xenkbd_remove':
> xen-kbdfront.c:(.text+0x2f0): undefined reference to `input_unregister_device'
> xen-kbdfront.c:(.text+0x30e): undefined reference to `input_unregister_device'
>
> This removes the extra "select", as it just causes more trouble than
> it helps. In theory, some defconfig file might break if it has
> XEN_FBDEV_FRONTEND in it but not INPUT_XEN_KBDDEV_FRONTEND. The Kconfig
> fragment we ship in the kernel (kernel/configs/xen.config) however
> already enables both, and anyone using an old .config file would
> keep having both enabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Suggested-by: David Vrabel <david.vrabel@citrix.com>
> Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND")
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 8ea45a5cd806..d889ef2048df 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -2246,7 +2246,6 @@ config XEN_FBDEV_FRONTEND
> select FB_SYS_IMAGEBLIT
> select FB_SYS_FOPS
> select FB_DEFERRED_IO
> - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
> select XEN_XENBUS_FRONTEND
> default y
> help
>
WARNING: multiple messages have this Message-ID (diff)
From: stefano.stabellini@eu.citrix.com (Stefano Stabellini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] xen kconfig: don't "select INPUT_XEN_KBDDEV_FRONTEND"
Date: Tue, 16 Feb 2016 16:55:42 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602161655350.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <2479546.WgivMO2bp2@wuerfel>
On Tue, 16 Feb 2016, Arnd Bergmann wrote:
> The Xen framebuffer driver selects the xen keyboard driver, so the latter
> will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT
> is a loadable module, this configuration cannot work. On mainline kernels,
> the symbol will be enabled but not used, while in combination with
> a patch I have to detect such useless configurations, we get the
> expected link failure:
>
> drivers/input/built-in.o: In function `xenkbd_remove':
> xen-kbdfront.c:(.text+0x2f0): undefined reference to `input_unregister_device'
> xen-kbdfront.c:(.text+0x30e): undefined reference to `input_unregister_device'
>
> This removes the extra "select", as it just causes more trouble than
> it helps. In theory, some defconfig file might break if it has
> XEN_FBDEV_FRONTEND in it but not INPUT_XEN_KBDDEV_FRONTEND. The Kconfig
> fragment we ship in the kernel (kernel/configs/xen.config) however
> already enables both, and anyone using an old .config file would
> keep having both enabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Suggested-by: David Vrabel <david.vrabel@citrix.com>
> Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND")
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 8ea45a5cd806..d889ef2048df 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -2246,7 +2246,6 @@ config XEN_FBDEV_FRONTEND
> select FB_SYS_IMAGEBLIT
> select FB_SYS_FOPS
> select FB_DEFERRED_IO
> - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
> select XEN_XENBUS_FRONTEND
> default y
> help
>
WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
David Vrabel <david.vrabel@citrix.com>,
Andrew Jones <drjones@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
linux-arm-kernel@lists.infradead.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xensource.com, boris.ostrovsky@oracle.com
Subject: Re: [PATCH v2] xen kconfig: don't "select INPUT_XEN_KBDDEV_FRONTEND"
Date: Tue, 16 Feb 2016 16:55:42 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602161655350.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <2479546.WgivMO2bp2@wuerfel>
On Tue, 16 Feb 2016, Arnd Bergmann wrote:
> The Xen framebuffer driver selects the xen keyboard driver, so the latter
> will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT
> is a loadable module, this configuration cannot work. On mainline kernels,
> the symbol will be enabled but not used, while in combination with
> a patch I have to detect such useless configurations, we get the
> expected link failure:
>
> drivers/input/built-in.o: In function `xenkbd_remove':
> xen-kbdfront.c:(.text+0x2f0): undefined reference to `input_unregister_device'
> xen-kbdfront.c:(.text+0x30e): undefined reference to `input_unregister_device'
>
> This removes the extra "select", as it just causes more trouble than
> it helps. In theory, some defconfig file might break if it has
> XEN_FBDEV_FRONTEND in it but not INPUT_XEN_KBDDEV_FRONTEND. The Kconfig
> fragment we ship in the kernel (kernel/configs/xen.config) however
> already enables both, and anyone using an old .config file would
> keep having both enabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Suggested-by: David Vrabel <david.vrabel@citrix.com>
> Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND")
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 8ea45a5cd806..d889ef2048df 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -2246,7 +2246,6 @@ config XEN_FBDEV_FRONTEND
> select FB_SYS_IMAGEBLIT
> select FB_SYS_FOPS
> select FB_DEFERRED_IO
> - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
> select XEN_XENBUS_FRONTEND
> default y
> help
>
next prev parent reply other threads:[~2016-02-16 16:56 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 12:04 [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Arnd Bergmann
2016-02-12 12:04 ` Arnd Bergmann
2016-02-12 12:04 ` Arnd Bergmann
2016-02-12 13:56 ` Andrew Jones
2016-02-12 13:56 ` Andrew Jones
2016-02-12 13:56 ` Andrew Jones
2016-02-15 16:51 ` Stefano Stabellini
2016-02-15 16:51 ` Stefano Stabellini
2016-02-15 16:51 ` Stefano Stabellini
2016-02-15 16:51 ` Stefano Stabellini
2016-02-15 17:05 ` David Vrabel
2016-02-15 17:05 ` David Vrabel
2016-02-15 17:05 ` David Vrabel
2016-02-15 17:05 ` David Vrabel
2016-02-15 17:08 ` Stefano Stabellini
2016-02-15 17:08 ` Stefano Stabellini
2016-02-15 17:08 ` Stefano Stabellini
2016-02-15 17:08 ` Stefano Stabellini
2016-02-16 15:03 ` [PATCH v2] xen kconfig: don't "select INPUT_XEN_KBDDEV_FRONTEND" Arnd Bergmann
2016-02-16 15:03 ` Arnd Bergmann
2016-02-16 15:03 ` Arnd Bergmann
2016-02-16 15:03 ` Arnd Bergmann
2016-02-16 16:55 ` Stefano Stabellini [this message]
2016-02-16 16:55 ` Stefano Stabellini
2016-02-16 16:55 ` Stefano Stabellini
2016-02-16 16:55 ` Stefano Stabellini
2016-03-11 11:37 ` Tomi Valkeinen
2016-03-11 11:37 ` Tomi Valkeinen
2016-03-11 11:37 ` Tomi Valkeinen
2016-03-11 11:37 ` Tomi Valkeinen
2016-02-16 11:35 ` [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Arnd Bergmann
2016-02-16 11:35 ` Arnd Bergmann
2016-02-16 11:35 ` Arnd Bergmann
2016-02-16 11:35 ` Arnd Bergmann
2016-02-16 12:14 ` Stefano Stabellini
2016-02-16 12:14 ` Stefano Stabellini
2016-02-16 12:14 ` Stefano Stabellini
2016-02-16 12:14 ` Stefano Stabellini
2016-02-16 15:05 ` Arnd Bergmann
2016-02-16 15:05 ` Arnd Bergmann
2016-02-16 15:05 ` Arnd Bergmann
2016-02-16 15:05 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1602161655350.27008@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=arnd@arndb.de \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=drjones@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.