Re: [Qemu-devel] [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

From: Stefano Stabellini <sstabellini@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Jan Beulich <JBeulich@suse.com>,
	anthony.perard@citrix.com,
	xen-devel <xen-devel@lists.xenproject.org>,
	qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix
Date: Fri, 17 Jun 2016 17:07:08 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1606171700590.18449@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <5762AE7B.4030402@suse.com>

On Thu, 16 Jun 2016, Juergen Gross wrote:
> On 16/06/16 15:07, Stefano Stabellini wrote:
> > On Thu, 16 Jun 2016, Juergen Gross wrote:
> >> On 16/06/16 12:54, Jan Beulich wrote:
> >>>>>> On 16.06.16 at 12:02, <JGross@suse.com> wrote:
> >>>> In case the word size of the domU and qemu running the qdisk backend
> >>>> differ BLKIF_OP_DISCARD will not work reliably, as the request
> >>>> structure in the ring have different layouts for different word size.
> >>>>
> >>>> Correct this by copying the request structure in case of different
> >>>> word size element by element in the BLKIF_OP_DISCARD case, too.
> >>>>
> >>>> Signed-off-by: Juergen Gross <jgross@suse.com>
> >>>
> >>> With the indentation (tabs vs blanks) fixed
> >>
> >> Hmm, qemu coding style is to use blanks. I could:
> >> a) leave the patch as is (changed lines indented with blanks)
> >> b) use tabs to indent (style of the modified file up to now)
> >> c) change the style of the file in this patch
> >> d) change the style of the file in a separate patch
> >>
> >> Any preferences?
> > 
> > I would go with d), fixing it to conform with QEMU coding style.
> 
> As I'm about to resync the header with the Linux one as Paul suggested
> it will be more like c). :-)

That's not a good idea, as you probably have noticed by now on the other
thread. This patch is OK, you just need to fix the intendation
separately.