From: Matthew DeVore <matvore@comcast.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthew DeVore <matvore@google.com>,
git@vger.kernel.org, pclouds@gmail.com, peff@peff.net,
jonathantanmy@google.com, jeffhost@microsoft.com
Subject: Re: [RFC 2/2] exclude-promisor-objects: declare when option is allowed
Date: Tue, 23 Oct 2018 10:55:49 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1810231053550.56374@matvore-linux.svl.corp.google.com> (raw)
In-Reply-To: <xmqqin1ts11h.fsf@gitster-ct.c.googlers.com>
On Tue, 23 Oct 2018, Junio C Hamano wrote:
> Not really. We were already doing a controlled failure via die(),
> so these two tests would not have caught the problem in the code
> before the fix in this patch.
>
BUG is apparently considered a "wrong" failure and not a controlled one
by test_must_fail. I just double-checked that the tests fail without
this patch.
not ok 119 - --exclude-promisor-objects does not BUG-crash
#
# test_must_fail git blame --exclude-promisor-objects one
#
# failed 1 among 119 test(s)
1..119
next prev parent reply other threads:[~2018-10-23 18:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 1:13 [RFC 0/2] explicitly support or not support --exclude-promisor-objects Matthew DeVore
2018-10-23 1:13 ` [RFC 1/2] Documentation/git-log.txt: do not show --exclude-promisor-objects Matthew DeVore
2018-10-23 1:13 ` [RFC 2/2] exclude-promisor-objects: declare when option is allowed Matthew DeVore
2018-10-23 5:08 ` Junio C Hamano
2018-10-23 17:55 ` Matthew DeVore [this message]
2018-10-24 1:31 ` Junio C Hamano
2018-11-21 16:40 ` Jeff King
2018-12-01 1:32 ` Matthew DeVore
2018-12-01 19:44 ` Jeff King
2018-12-03 19:10 ` Matthew DeVore
2018-12-03 21:15 ` Jeff King
2018-12-03 21:54 ` Matthew DeVore
2018-12-04 2:20 ` Junio C Hamano
2018-12-03 19:23 ` [PATCH] revisions.c: put promisor option in specialized struct Matthew DeVore
2018-12-03 21:24 ` Jeff King
2018-12-03 22:01 ` Matthew DeVore
2018-10-23 1:18 ` [RFC 0/2] explicitly support or not support --exclude-promisor-objects Matthew DeVore
2018-10-23 4:48 ` Junio C Hamano
2018-10-23 17:09 ` Matthew DeVore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1810231053550.56374@matvore-linux.svl.corp.google.com \
--to=matvore@comcast.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=matvore@google.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.