From: Junio C Hamano <gitster@pobox.com>
To: Matthew DeVore <matvore@google.com>
Cc: git@vger.kernel.org, pclouds@gmail.com, peff@peff.net,
jonathantanmy@google.com, jeffhost@microsoft.com,
matvore@comcast.net
Subject: Re: [RFC 0/2] explicitly support or not support --exclude-promisor-objects
Date: Tue, 23 Oct 2018 13:48:30 +0900 [thread overview]
Message-ID: <xmqqmur5s1y9.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <cover.1540256910.git.matvore@google.com> (Matthew DeVore's message of "Mon, 22 Oct 2018 18:13:40 -0700")
Matthew DeVore <matvore@google.com> writes:
> This patch set fixes incorrect parsing of the --exclude-promisor-objects
> option that I found while working on:
>
> https://public-inbox.org/git/cover.1539298957.git.matvore@google.com/
>
Thanks; both patches make sense.
As the problematic feature appeared in 2.17.x track, I'll see if I
can easily make it ready to be merged down to maint-2.17 track later
when somebody wants to.
> Matthew DeVore (2):
> Documentation/git-log.txt: do not show --exclude-promisor-objects
> exclude-promisor-objects: declare when option is allowed
>
> Documentation/rev-list-options.txt | 2 +-
> builtin/pack-objects.c | 1 +
> builtin/prune.c | 1 +
> builtin/rev-list.c | 1 +
> revision.c | 3 ++-
> revision.h | 1 +
> t/t4202-log.sh | 4 ++++
> t/t8002-blame.sh | 4 ++++
> 8 files changed, 15 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2018-10-23 4:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 1:13 [RFC 0/2] explicitly support or not support --exclude-promisor-objects Matthew DeVore
2018-10-23 1:13 ` [RFC 1/2] Documentation/git-log.txt: do not show --exclude-promisor-objects Matthew DeVore
2018-10-23 1:13 ` [RFC 2/2] exclude-promisor-objects: declare when option is allowed Matthew DeVore
2018-10-23 5:08 ` Junio C Hamano
2018-10-23 17:55 ` Matthew DeVore
2018-10-24 1:31 ` Junio C Hamano
2018-11-21 16:40 ` Jeff King
2018-12-01 1:32 ` Matthew DeVore
2018-12-01 19:44 ` Jeff King
2018-12-03 19:10 ` Matthew DeVore
2018-12-03 21:15 ` Jeff King
2018-12-03 21:54 ` Matthew DeVore
2018-12-04 2:20 ` Junio C Hamano
2018-12-03 19:23 ` [PATCH] revisions.c: put promisor option in specialized struct Matthew DeVore
2018-12-03 21:24 ` Jeff King
2018-12-03 22:01 ` Matthew DeVore
2018-10-23 1:18 ` [RFC 0/2] explicitly support or not support --exclude-promisor-objects Matthew DeVore
2018-10-23 4:48 ` Junio C Hamano [this message]
2018-10-23 17:09 ` Matthew DeVore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmur5s1y9.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=matvore@comcast.net \
--cc=matvore@google.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.