From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Joe Perches <joe@perches.com>,
cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
David Laight <David.Laight@ACULAB.COM>
Subject: Re: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms
Date: Thu, 25 Jul 2019 06:34:38 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1907250632500.2535@hadrien> (raw)
In-Reply-To: <e3a37d93-0353-ebed-948a-991add184616@web.de>
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
On Thu, 25 Jul 2019, Markus Elfring wrote:
> > New version. I check for non-use of the return value of strlcpy and
> > address some issues that affected the matching of the case where the first
> > argument involves a pointer dereference.
>
> I suggest to take another look at corresponding implementation details
> of the shown SmPL script.
>
>
> > \(strscpy\|strlcpy\)(e1.f, e2, i2)@p
>
> Can the data access operator “->” (arrow) matter also here?
What did my email say about isomorphisms?
>
>
> > @@
> > identifier r.i1,r.i2;
> > type T;
> > @@
> > struct i1 { ... T i1[i2]; ... }
>
> Will an additional SmPL rule name be helpful for this part?
Yes, sorry, it would seem that that is necessary. I will fix and resend
the results.
>
>
> > @@
> > (
> > -x = strlcpy
> > +stracpy
> > (e1.f, e2
> > - , i2
> > )@p;
> > ... when != x
> >
> > |
>
> I wonder about the deletion of the assignment target.
> Should the setting of such a variable be usually preserved?
If it is a local variable and never subsequently used, it doesn't seem
very useful.
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Joe Perches <joe@perches.com>,
David Laight <David.Laight@ACULAB.COM>,
kernel-janitors@vger.kernel.org, cocci@systeme.lip6.fr,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms
Date: Thu, 25 Jul 2019 11:34:38 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1907250632500.2535@hadrien> (raw)
In-Reply-To: <e3a37d93-0353-ebed-948a-991add184616@web.de>
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
On Thu, 25 Jul 2019, Markus Elfring wrote:
> > New version. I check for non-use of the return value of strlcpy and
> > address some issues that affected the matching of the case where the first
> > argument involves a pointer dereference.
>
> I suggest to take another look at corresponding implementation details
> of the shown SmPL script.
>
>
> > \(strscpy\|strlcpy\)(e1.f, e2, i2)@p
>
> Can the data access operator “->” (arrow) matter also here?
What did my email say about isomorphisms?
>
>
> > @@
> > identifier r.i1,r.i2;
> > type T;
> > @@
> > struct i1 { ... T i1[i2]; ... }
>
> Will an additional SmPL rule name be helpful for this part?
Yes, sorry, it would seem that that is necessary. I will fix and resend
the results.
>
>
> > @@
> > (
> > -x = strlcpy
> > +stracpy
> > (e1.f, e2
> > - , i2
> > )@p;
> > ... when != x
> >
> > |
>
> I wonder about the deletion of the assignment target.
> Should the setting of such a variable be usually preserved?
If it is a local variable and never subsequently used, it doesn't seem
very useful.
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Joe Perches <joe@perches.com>,
David Laight <David.Laight@ACULAB.COM>,
kernel-janitors@vger.kernel.org, cocci@systeme.lip6.fr,
linux-kernel@vger.kernel.org
Subject: Re: [Cocci] [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms
Date: Thu, 25 Jul 2019 06:34:38 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1907250632500.2535@hadrien> (raw)
In-Reply-To: <e3a37d93-0353-ebed-948a-991add184616@web.de>
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
On Thu, 25 Jul 2019, Markus Elfring wrote:
> > New version. I check for non-use of the return value of strlcpy and
> > address some issues that affected the matching of the case where the first
> > argument involves a pointer dereference.
>
> I suggest to take another look at corresponding implementation details
> of the shown SmPL script.
>
>
> > \(strscpy\|strlcpy\)(e1.f, e2, i2)@p
>
> Can the data access operator “->” (arrow) matter also here?
What did my email say about isomorphisms?
>
>
> > @@
> > identifier r.i1,r.i2;
> > type T;
> > @@
> > struct i1 { ... T i1[i2]; ... }
>
> Will an additional SmPL rule name be helpful for this part?
Yes, sorry, it would seem that that is necessary. I will fix and resend
the results.
>
>
> > @@
> > (
> > -x = strlcpy
> > +stracpy
> > (e1.f, e2
> > - , i2
> > )@p;
> > ... when != x
> >
> > |
>
> I wonder about the deletion of the assignment target.
> Should the setting of such a variable be usually preserved?
If it is a local variable and never subsequently used, it doesn't seem
very useful.
julia
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-07-25 11:34 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 0:38 [PATCH 0/2] string: Add stracpy and stracpy_pad Joe Perches
2019-07-23 0:38 ` [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms Joe Perches
2019-07-23 0:46 ` [Cocci] [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] Joe Perches
2019-07-23 20:52 ` Julia Lawall
2019-07-23 20:52 ` [Cocci] " Julia Lawall
2019-07-23 23:42 ` Joe Perches
2019-07-23 23:42 ` [Cocci] " Joe Perches
2019-07-24 3:54 ` Julia Lawall
2019-07-24 3:54 ` [Cocci] " Julia Lawall
2019-07-24 4:19 ` Joe Perches
2019-07-24 4:19 ` [Cocci] " Joe Perches
2019-07-24 4:27 ` Julia Lawall
2019-07-24 4:27 ` [Cocci] " Julia Lawall
2019-07-24 4:37 ` Joe Perches
2019-07-24 4:37 ` [Cocci] " Joe Perches
2019-07-24 10:28 ` David Laight
2019-07-24 10:28 ` [Cocci] " David Laight
2019-07-24 10:43 ` Joe Perches
2019-07-24 10:43 ` [Cocci] " Joe Perches
2019-07-24 11:45 ` Julia Lawall
2019-07-24 11:45 ` [Cocci] " Julia Lawall
2019-07-25 1:42 ` Julia Lawall
2019-07-25 1:42 ` [Cocci] " Julia Lawall
2019-07-25 7:46 ` [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms Markus Elfring
2019-07-25 7:46 ` [Cocci] " Markus Elfring
2019-07-25 7:46 ` Markus Elfring
2019-07-25 11:34 ` Julia Lawall [this message]
2019-07-25 11:34 ` [Cocci] " Julia Lawall
2019-07-25 11:34 ` Julia Lawall
2019-07-25 12:40 ` [1/2] " Markus Elfring
2019-07-25 12:40 ` [Cocci] " Markus Elfring
2019-07-25 12:40 ` Markus Elfring
2019-07-25 13:45 ` [PATCH 1/2] " Markus Elfring
2019-07-25 13:45 ` [Cocci] " Markus Elfring
2019-07-25 13:45 ` Markus Elfring
2019-07-25 13:48 ` Julia Lawall
2019-07-25 13:48 ` [Cocci] " Julia Lawall
2019-07-25 13:48 ` Julia Lawall
2019-07-25 14:48 ` [1/2] " Markus Elfring
2019-07-25 14:48 ` [Cocci] " Markus Elfring
2019-07-25 14:48 ` Markus Elfring
2019-07-25 13:50 ` [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] Joe Perches
2019-07-25 13:50 ` [Cocci] " Joe Perches
2019-07-25 13:58 ` Julia Lawall
2019-07-25 13:58 ` [Cocci] " Julia Lawall
2019-07-25 14:12 ` Joe Perches
2019-07-25 14:12 ` [Cocci] " Joe Perches
2019-07-25 22:51 ` Julia Lawall
2019-07-25 22:51 ` [Cocci] " Julia Lawall
2019-07-26 6:15 ` [1/2] string: Add stracpy and stracpy_pad mechanisms Markus Elfring
2019-07-26 6:15 ` [Cocci] " Markus Elfring
2019-07-26 6:15 ` Markus Elfring
2019-07-29 14:07 ` [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] Julia Lawall
2019-07-29 14:07 ` [Cocci] " Julia Lawall
2019-07-29 16:28 ` Joe Perches
2019-07-29 16:28 ` [Cocci] " Joe Perches
2019-07-23 4:35 ` [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms Andrew Morton
2019-07-23 4:42 ` Joe Perches
2019-07-23 4:42 ` Joe Perches
2019-07-23 21:29 ` Kees Cook
2019-07-23 6:55 ` Rasmus Villemoes
2019-07-23 15:41 ` David Laight
2019-07-23 15:41 ` David Laight
2019-07-23 15:50 ` Joe Perches
2019-07-23 15:50 ` Joe Perches
2019-07-23 21:34 ` Kees Cook
2019-07-23 21:34 ` Kees Cook
2019-07-24 12:05 ` Yann Droneaud
2019-07-24 12:05 ` Yann Droneaud
2019-07-24 13:09 ` Rasmus Villemoes
2019-07-24 13:09 ` Rasmus Villemoes
2019-07-24 17:08 ` Linus Torvalds
2019-07-24 17:08 ` Linus Torvalds
2019-07-25 20:03 ` Kees Cook
2019-07-25 20:03 ` Kees Cook
2019-07-26 2:46 ` Joe Perches
2019-07-26 2:46 ` Joe Perches
2019-07-23 21:36 ` Kees Cook
2019-07-24 11:40 ` Joe Perches
2019-07-24 11:40 ` Joe Perches
2019-07-23 0:38 ` [PATCH 2/2] kernel-doc: core-api: Include string.h into core-api Joe Perches
2019-07-23 21:28 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1907250632500.2535@hadrien \
--to=julia.lawall@lip6.fr \
--cc=David.Laight@ACULAB.COM \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.