From: Stefano Stabellini <sstabellini@kernel.org>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk,
xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] xen: mm: include <xen/xen-ops.h> for missing declarations
Date: Tue, 22 Oct 2019 10:08:43 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1910221008370.30080@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20191022125006.3746-1-ben.dooks@codethink.co.uk>
On Tue, 22 Oct 2019, Ben Dooks (Codethink) wrote:
> Include <xen/xen-ops.h> for xen_{create,destroy}_contigous_region
> call declarations. Fixes the following sparse warnings:
>
> arch/arm/xen/mm.c:119:5: warning: symbol 'xen_create_contiguous_region' was not declared. Should it be static?
> arch/arm/xen/mm.c:131:6: warning: symbol 'xen_destroy_contiguous_region' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: xen-devel@lists.xenproject.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/xen/mm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> index 38fa917c8585..6feb6b78b13c 100644
> --- a/arch/arm/xen/mm.c
> +++ b/arch/arm/xen/mm.c
> @@ -15,6 +15,7 @@
> #include <xen/interface/grant_table.h>
> #include <xen/interface/memory.h>
> #include <xen/page.h>
> +#include <xen/xen-ops.h>
> #include <xen/swiotlb-xen.h>
>
> #include <asm/cacheflush.h>
> --
> 2.23.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <sstabellini@kernel.org>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk,
xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Xen-devel] [PATCH] xen: mm: include <xen/xen-ops.h> for missing declarations
Date: Tue, 22 Oct 2019 10:08:43 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1910221008370.30080@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20191022125006.3746-1-ben.dooks@codethink.co.uk>
On Tue, 22 Oct 2019, Ben Dooks (Codethink) wrote:
> Include <xen/xen-ops.h> for xen_{create,destroy}_contigous_region
> call declarations. Fixes the following sparse warnings:
>
> arch/arm/xen/mm.c:119:5: warning: symbol 'xen_create_contiguous_region' was not declared. Should it be static?
> arch/arm/xen/mm.c:131:6: warning: symbol 'xen_destroy_contiguous_region' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: xen-devel@lists.xenproject.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/xen/mm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> index 38fa917c8585..6feb6b78b13c 100644
> --- a/arch/arm/xen/mm.c
> +++ b/arch/arm/xen/mm.c
> @@ -15,6 +15,7 @@
> #include <xen/interface/grant_table.h>
> #include <xen/interface/memory.h>
> #include <xen/page.h>
> +#include <xen/xen-ops.h>
> #include <xen/swiotlb-xen.h>
>
> #include <asm/cacheflush.h>
> --
> 2.23.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-22 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 12:50 [PATCH] xen: mm: include <xen/xen-ops.h> for missing declarations Ben Dooks (Codethink)
2019-10-22 12:50 ` [Xen-devel] " Ben Dooks (Codethink)
2019-10-22 17:08 ` Stefano Stabellini [this message]
2019-10-22 17:08 ` Stefano Stabellini
2019-10-22 17:09 ` Stefano Stabellini
2019-10-22 17:09 ` [Xen-devel] " Stefano Stabellini
2019-10-23 7:31 ` Ben Dooks
2019-10-23 7:31 ` [Xen-devel] " Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910221008370.30080@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux@armlinux.org.uk \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.