From: "Maciej W. Rozycki" <macro@orcam.me.uk> To: Bjorn Helgaas <bhelgaas@google.com>, Mahesh J Salgaonkar <mahesh@linux.ibm.com>, Oliver O'Halloran <oohall@gmail.com>, Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>, Christophe Leroy <christophe.leroy@csgroup.eu>, Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com> Cc: "Alex Williamson" <alex.williamson@redhat.com>, "Lukas Wunner" <lukas@wunner.de>, "Mika Westerberg" <mika.westerberg@linux.intel.com>, "Stefan Roese" <sr@denx.de>, "Jim Wilson" <wilson@tuliptree.org>, "David Abdurachmanov" <david.abdurachmanov@gmail.com>, "Pali Rohár" <pali@kernel.org>, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 6/7] PCI: pciehp: Rely on `link_active_reporting' Date: Tue, 4 Apr 2023 22:56:21 +0100 (BST) [thread overview] Message-ID: <alpine.DEB.2.21.2304042243250.37565@angie.orcam.me.uk> (raw) In-Reply-To: <alpine.DEB.2.21.2304042200040.37565@angie.orcam.me.uk> Use `link_active_reporting' to determine whether Data Link Layer Link Active Reporting is available rather than re-retrieving the capability. Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk> --- NB this has been compile-tested only with PPC64LE and x86-64 configurations. No change from v6. New change in v6. --- drivers/pci/hotplug/pciehp_hpc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) linux-pcie-link-active-reporting-hpc.diff Index: linux-macro/drivers/pci/hotplug/pciehp_hpc.c =================================================================== --- linux-macro.orig/drivers/pci/hotplug/pciehp_hpc.c +++ linux-macro/drivers/pci/hotplug/pciehp_hpc.c @@ -984,7 +984,7 @@ static inline int pcie_hotplug_depth(str struct controller *pcie_init(struct pcie_device *dev) { struct controller *ctrl; - u32 slot_cap, slot_cap2, link_cap; + u32 slot_cap, slot_cap2; u8 poweron; struct pci_dev *pdev = dev->port; struct pci_bus *subordinate = pdev->subordinate; @@ -1030,9 +1030,6 @@ struct controller *pcie_init(struct pcie if (dmi_first_match(inband_presence_disabled_dmi_table)) ctrl->inband_presence_disabled = 1; - /* Check if Data Link Layer Link Active Reporting is implemented */ - pcie_capability_read_dword(pdev, PCI_EXP_LNKCAP, &link_cap); - /* Clear all remaining event bits in Slot Status register. */ pcie_capability_write_word(pdev, PCI_EXP_SLTSTA, PCI_EXP_SLTSTA_ABP | PCI_EXP_SLTSTA_PFD | @@ -1051,7 +1048,7 @@ struct controller *pcie_init(struct pcie FLAG(slot_cap, PCI_EXP_SLTCAP_EIP), FLAG(slot_cap, PCI_EXP_SLTCAP_NCCS), FLAG(slot_cap2, PCI_EXP_SLTCAP2_IBPD), - FLAG(link_cap, PCI_EXP_LNKCAP_DLLLARC), + FLAG(pdev->link_active_reporting, true), pdev->broken_cmd_compl ? " (with Cmd Compl erratum)" : ""); /*
WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@orcam.me.uk> To: Bjorn Helgaas <bhelgaas@google.com>, Mahesh J Salgaonkar <mahesh@linux.ibm.com>, Oliver O'Halloran <oohall@gmail.com>, Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>, Christophe Leroy <christophe.leroy@csgroup.eu>, Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com> Cc: "Pali Rohár" <pali@kernel.org>, "David Abdurachmanov" <david.abdurachmanov@gmail.com>, linux-rdma@vger.kernel.org, "Mika Westerberg" <mika.westerberg@linux.intel.com>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, "Alex Williamson" <alex.williamson@redhat.com>, "Lukas Wunner" <lukas@wunner.de>, linux-pci@vger.kernel.org, "Stefan Roese" <sr@denx.de>, "Jim Wilson" <wilson@tuliptree.org>, netdev@vger.kernel.org Subject: [PATCH v7 6/7] PCI: pciehp: Rely on `link_active_reporting' Date: Tue, 4 Apr 2023 22:56:21 +0100 (BST) [thread overview] Message-ID: <alpine.DEB.2.21.2304042243250.37565@angie.orcam.me.uk> (raw) In-Reply-To: <alpine.DEB.2.21.2304042200040.37565@angie.orcam.me.uk> Use `link_active_reporting' to determine whether Data Link Layer Link Active Reporting is available rather than re-retrieving the capability. Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk> --- NB this has been compile-tested only with PPC64LE and x86-64 configurations. No change from v6. New change in v6. --- drivers/pci/hotplug/pciehp_hpc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) linux-pcie-link-active-reporting-hpc.diff Index: linux-macro/drivers/pci/hotplug/pciehp_hpc.c =================================================================== --- linux-macro.orig/drivers/pci/hotplug/pciehp_hpc.c +++ linux-macro/drivers/pci/hotplug/pciehp_hpc.c @@ -984,7 +984,7 @@ static inline int pcie_hotplug_depth(str struct controller *pcie_init(struct pcie_device *dev) { struct controller *ctrl; - u32 slot_cap, slot_cap2, link_cap; + u32 slot_cap, slot_cap2; u8 poweron; struct pci_dev *pdev = dev->port; struct pci_bus *subordinate = pdev->subordinate; @@ -1030,9 +1030,6 @@ struct controller *pcie_init(struct pcie if (dmi_first_match(inband_presence_disabled_dmi_table)) ctrl->inband_presence_disabled = 1; - /* Check if Data Link Layer Link Active Reporting is implemented */ - pcie_capability_read_dword(pdev, PCI_EXP_LNKCAP, &link_cap); - /* Clear all remaining event bits in Slot Status register. */ pcie_capability_write_word(pdev, PCI_EXP_SLTSTA, PCI_EXP_SLTSTA_ABP | PCI_EXP_SLTSTA_PFD | @@ -1051,7 +1048,7 @@ struct controller *pcie_init(struct pcie FLAG(slot_cap, PCI_EXP_SLTCAP_EIP), FLAG(slot_cap, PCI_EXP_SLTCAP_NCCS), FLAG(slot_cap2, PCI_EXP_SLTCAP2_IBPD), - FLAG(link_cap, PCI_EXP_LNKCAP_DLLLARC), + FLAG(pdev->link_active_reporting, true), pdev->broken_cmd_compl ? " (with Cmd Compl erratum)" : ""); /*
next prev parent reply other threads:[~2023-04-04 21:56 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-04 21:55 [PATCH v7 0/7] pci: Work around ASMedia ASM2824 PCIe link training failures Maciej W. Rozycki 2023-04-04 21:55 ` Maciej W. Rozycki 2023-04-04 21:55 ` [PATCH v7 1/7] PCI: Export PCI link retrain timeout Maciej W. Rozycki 2023-04-04 21:55 ` Maciej W. Rozycki 2023-04-04 21:56 ` [PATCH v7 2/7] PCI: Execute `quirk_enable_clear_retrain_link' earlier Maciej W. Rozycki 2023-04-04 21:56 ` Maciej W. Rozycki 2023-04-04 21:56 ` [PATCH v7 3/7] PCI: Initialize `link_active_reporting' earlier Maciej W. Rozycki 2023-04-04 21:56 ` Maciej W. Rozycki 2023-04-04 21:56 ` [PATCH v7 4/7] powerpc/eeh: Rely on `link_active_reporting' Maciej W. Rozycki 2023-04-04 21:56 ` Maciej W. Rozycki 2023-04-04 21:56 ` [PATCH v7 5/7] net/mlx5: " Maciej W. Rozycki 2023-04-04 21:56 ` Maciej W. Rozycki 2023-04-04 21:56 ` Maciej W. Rozycki [this message] 2023-04-04 21:56 ` [PATCH v7 6/7] PCI: pciehp: " Maciej W. Rozycki 2023-04-05 7:18 ` Lukas Wunner 2023-04-05 11:51 ` Maciej W. Rozycki 2023-04-04 21:56 ` [PATCH v7 7/7] PCI: Work around PCIe link training failures Maciej W. Rozycki 2023-04-04 21:56 ` Maciej W. Rozycki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.21.2304042243250.37565@angie.orcam.me.uk \ --to=macro@orcam.me.uk \ --cc=alex.williamson@redhat.com \ --cc=bhelgaas@google.com \ --cc=christophe.leroy@csgroup.eu \ --cc=davem@davemloft.net \ --cc=david.abdurachmanov@gmail.com \ --cc=edumazet@google.com \ --cc=kuba@kernel.org \ --cc=leon@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=lukas@wunner.de \ --cc=mahesh@linux.ibm.com \ --cc=mika.westerberg@linux.intel.com \ --cc=mpe@ellerman.id.au \ --cc=netdev@vger.kernel.org \ --cc=npiggin@gmail.com \ --cc=oohall@gmail.com \ --cc=pabeni@redhat.com \ --cc=pali@kernel.org \ --cc=saeedm@nvidia.com \ --cc=sr@denx.de \ --cc=wilson@tuliptree.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.