All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	 Richard Henderson <richard.henderson@linaro.org>,
	 Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	 Matt Turner <mattst88@gmail.com>,
	Vineet Gupta <vgupta@kernel.org>,
	 Russell King <linux@armlinux.org.uk>,
	 Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	 Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	 Geert Uytterhoeven <geert@linux-m68k.org>,
	Michal Simek <monstr@monstr.eu>,
	 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	 "James E . J . Bottomley"
	<James.Bottomley@HansenPartnership.com>,
	 Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	 Nicholas Piggin <npiggin@gmail.com>,
	 Christophe Leroy <christophe.leroy@csgroup.eu>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	 Alexander Gordeev <agordeev@linux.ibm.com>,
	 Christian Borntraeger <borntraeger@linux.ibm.com>,
	 Sven Schnelle <svens@linux.ibm.com>,
	 Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	 "David S . Miller" <davem@davemloft.net>,
	 Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,  Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	 x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	 Chris Zankel <chris@zankel.net>,
	Max Filippov <jcmvbkbc@gmail.com>,  Arnd Bergmann <arnd@arndb.de>,
	linux-doc@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-alpha@vger.kernel.org,  linux-snps-arc@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-ia64@vger.kernel.org, loongarch@lists.linux.dev,
	 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
	 linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	 linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	 linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
	 linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org,
	 Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: [PATCH v5 14/26] alpha: Remove empty <uapi/asm/setup.h>
Date: Tue, 16 May 2023 01:53:45 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2305160147100.11892@angie.orcam.me.uk> (raw)
In-Reply-To: <20230306100508.1171812-15-alexghiti@rivosinc.com>

On Mon, 6 Mar 2023, Alexandre Ghiti wrote:

> diff --git a/arch/alpha/include/uapi/asm/setup.h b/arch/alpha/include/uapi/asm/setup.h
> deleted file mode 100644
> index 9b3b5ba39b1d..000000000000
> --- a/arch/alpha/include/uapi/asm/setup.h
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> -#ifndef _UAPI__ALPHA_SETUP_H
> -#define _UAPI__ALPHA_SETUP_H
> -
> -#endif /* _UAPI__ALPHA_SETUP_H */

 You can't just remove a UAPI header like this, something will break; cf. 
arch/arc/include/uapi/asm/setup.h, or arch/x86/include/uapi/asm/setup.h if 
you want it brief.

 I suggest that you fold it into 01/26 (it makes no sense to have empty 
multiple inclusion protection), and likewise for the relevant remaining 
headers.

  Maciej

WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	 Richard Henderson <richard.henderson@linaro.org>,
	 Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	 Matt Turner <mattst88@gmail.com>,
	Vineet Gupta <vgupta@kernel.org>,
	 Russell King <linux@armlinux.org.uk>,
	 Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	 Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	 Geert Uytterhoeven <geert@linux-m68k.org>,
	Michal Simek <monstr@monstr.eu>,
	 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	 "James E . J . Bottomley"
	<James.Bottomley@HansenPartnership.com>,
	 Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	 Nicholas Piggin <npiggin@gmail.com>,
	 Christophe Leroy <christophe.leroy@csgroup.eu>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	 Alexander Gordeev <agordeev@linux.ibm.com>,
	 Christian Borntraeger <borntraeger@linux.ibm.com>,
	 Sven Schnelle <svens@linux.ibm.com>,
	 Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	 "David S . Miller" <davem@davemloft.net>,
	 Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,  Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	 x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	 Chris Zankel <chris@zankel.net>,
	Max Filippov <jcmvbkbc@gmail.com>,  Arnd Bergmann <arnd@arndb.de>,
	linux-doc@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-alpha@vger.kernel.org,  linux-snps-arc@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-ia64@vger.kernel.org, loongarch@lists.linux.dev,
	 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
	 linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	 linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	 linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
	 linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org,
	 Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: [PATCH v5 14/26] alpha: Remove empty <uapi/asm/setup.h>
Date: Tue, 16 May 2023 01:53:45 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2305160147100.11892@angie.orcam.me.uk> (raw)
In-Reply-To: <20230306100508.1171812-15-alexghiti@rivosinc.com>

On Mon, 6 Mar 2023, Alexandre Ghiti wrote:

> diff --git a/arch/alpha/include/uapi/asm/setup.h b/arch/alpha/include/uapi/asm/setup.h
> deleted file mode 100644
> index 9b3b5ba39b1d..000000000000
> --- a/arch/alpha/include/uapi/asm/setup.h
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> -#ifndef _UAPI__ALPHA_SETUP_H
> -#define _UAPI__ALPHA_SETUP_H
> -
> -#endif /* _UAPI__ALPHA_SETUP_H */

 You can't just remove a UAPI header like this, something will break; cf. 
arch/arc/include/uapi/asm/setup.h, or arch/x86/include/uapi/asm/setup.h if 
you want it brief.

 I suggest that you fold it into 01/26 (it makes no sense to have empty 
multiple inclusion protection), and likewise for the relevant remaining 
headers.

  Maciej

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	 Richard Henderson <richard.henderson@linaro.org>,
	 Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	 Matt Turner <mattst88@gmail.com>,
	Vineet Gupta <vgupta@kernel.org>,
	 Russell King <linux@armlinux.org.uk>,
	 Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	 Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	 Geert Uytterhoeven <geert@linux-m68k.org>,
	Michal Simek <monstr@monstr.eu>,
	 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	 "James E . J . Bottomley"
	<James.Bottomley@HansenPartnership.com>,
	 Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	 Nicholas Piggin <npiggin@gmail.com>,
	 Christophe Leroy <christophe.leroy@csgroup.eu>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	 Alexander Gordeev <agordeev@linux.ibm.com>,
	 Christian Borntraeger <borntraeger@linux.ibm.com>,
	 Sven Schnelle <svens@linux.ibm.com>,
	 Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	 "David S . Miller" <davem@davemloft.net>,
	 Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,  Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	 x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	 Chris Zankel <chris@zankel.net>,
	Max Filippov <jcmvbkbc@gmail.com>,  Arnd Bergmann <arnd@arndb.de>,
	linux-doc@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-alpha@vger.kernel.org,  linux-snps-arc@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-ia64@vger.kernel.org, loongarch@lists.linux.dev,
	 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
	 linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	 linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	 linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
	 linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org,
	 Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: [PATCH v5 14/26] alpha: Remove empty <uapi/asm/setup.h>
Date: Tue, 16 May 2023 01:53:45 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2305160147100.11892@angie.orcam.me.uk> (raw)
In-Reply-To: <20230306100508.1171812-15-alexghiti@rivosinc.com>

On Mon, 6 Mar 2023, Alexandre Ghiti wrote:

> diff --git a/arch/alpha/include/uapi/asm/setup.h b/arch/alpha/include/uapi/asm/setup.h
> deleted file mode 100644
> index 9b3b5ba39b1d..000000000000
> --- a/arch/alpha/include/uapi/asm/setup.h
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> -#ifndef _UAPI__ALPHA_SETUP_H
> -#define _UAPI__ALPHA_SETUP_H
> -
> -#endif /* _UAPI__ALPHA_SETUP_H */

 You can't just remove a UAPI header like this, something will break; cf. 
arch/arc/include/uapi/asm/setup.h, or arch/x86/include/uapi/asm/setup.h if 
you want it brief.

 I suggest that you fold it into 01/26 (it makes no sense to have empty 
multiple inclusion protection), and likewise for the relevant remaining 
headers.

  Maciej

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: Rich Felker <dalias@libc.org>,
	linux-ia64@vger.kernel.org, linux-doc@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, Palmer Dabbelt <palmer@rivosinc.com>,
	linux-mips@vger.kernel.org,
	"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
	Max Filippov <jcmvbkbc@gmail.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	sparclinux@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
	Will Deacon <will@kernel.org>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-snps-arc@lists.infradead.org, Arnd Bergmann <arnd@arndb.de>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-sh@vger.kernel.org, Helge Deller <deller@gmx.de>,
	Huacai Chen <chenhuacai@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Ingo Molnar <mingo@redhat.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Vineet Gupta <vgupta@kernel.org>,
	Matt Turner <mattst88@gma il.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	linux-xtensa@linux-xtensa.org, Albert Ou <aou@eecs.berkeley.edu>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	linux-m68k@lists.linux-m68k.org,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	loongarch@lists.linux.dev,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	Chris Zankel <chris@zankel.net>, Michal Simek <monstr@monstr.eu>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-parisc@vger.kernel.org,
	Greg KH <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	linux-alpha@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
	linuxppc-dev@lists.ozlabs.org,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v5 14/26] alpha: Remove empty <uapi/asm/setup.h>
Date: Tue, 16 May 2023 01:53:45 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2305160147100.11892@angie.orcam.me.uk> (raw)
In-Reply-To: <20230306100508.1171812-15-alexghiti@rivosinc.com>

On Mon, 6 Mar 2023, Alexandre Ghiti wrote:

> diff --git a/arch/alpha/include/uapi/asm/setup.h b/arch/alpha/include/uapi/asm/setup.h
> deleted file mode 100644
> index 9b3b5ba39b1d..000000000000
> --- a/arch/alpha/include/uapi/asm/setup.h
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> -#ifndef _UAPI__ALPHA_SETUP_H
> -#define _UAPI__ALPHA_SETUP_H
> -
> -#endif /* _UAPI__ALPHA_SETUP_H */

 You can't just remove a UAPI header like this, something will break; cf. 
arch/arc/include/uapi/asm/setup.h, or arch/x86/include/uapi/asm/setup.h if 
you want it brief.

 I suggest that you fold it into 01/26 (it makes no sense to have empty 
multiple inclusion protection), and likewise for the relevant remaining 
headers.

  Maciej

WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Richard Henderson <richard.henderson@linaro.org>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	Vineet Gupta <vgupta@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Michal Simek <monstr@monstr.eu>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	"David S . Miller" <davem@davemloft.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	Chris Zankel <chris@zankel.net>,
	Max Filippov <jcmvbkbc@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
	loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
	sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org,
	linux-arch@vger.kernel.org, Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: [PATCH v5 14/26] alpha: Remove empty <uapi/asm/setup.h>
Date: Tue, 16 May 2023 00:53:45 +0000	[thread overview]
Message-ID: <alpine.DEB.2.21.2305160147100.11892@angie.orcam.me.uk> (raw)
In-Reply-To: <20230306100508.1171812-15-alexghiti@rivosinc.com>

On Mon, 6 Mar 2023, Alexandre Ghiti wrote:

> diff --git a/arch/alpha/include/uapi/asm/setup.h b/arch/alpha/include/uapi/asm/setup.h
> deleted file mode 100644
> index 9b3b5ba39b1d..000000000000
> --- a/arch/alpha/include/uapi/asm/setup.h
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> -#ifndef _UAPI__ALPHA_SETUP_H
> -#define _UAPI__ALPHA_SETUP_H
> -
> -#endif /* _UAPI__ALPHA_SETUP_H */

 You can't just remove a UAPI header like this, something will break; cf. 
arch/arc/include/uapi/asm/setup.h, or arch/x86/include/uapi/asm/setup.h if 
you want it brief.

 I suggest that you fold it into 01/26 (it makes no sense to have empty 
multiple inclusion protection), and likewise for the relevant remaining 
headers.

  Maciej

WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Richard Henderson <richard.henderson@linaro.org>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	Vineet Gupta <vgupta@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Michal Simek <monstr@monstr.eu>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <christophe.leroy@csg>
Subject: Re: [PATCH v5 14/26] alpha: Remove empty <uapi/asm/setup.h>
Date: Tue, 16 May 2023 01:53:45 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2305160147100.11892@angie.orcam.me.uk> (raw)
In-Reply-To: <20230306100508.1171812-15-alexghiti@rivosinc.com>

On Mon, 6 Mar 2023, Alexandre Ghiti wrote:

> diff --git a/arch/alpha/include/uapi/asm/setup.h b/arch/alpha/include/uapi/asm/setup.h
> deleted file mode 100644
> index 9b3b5ba39b1d..000000000000
> --- a/arch/alpha/include/uapi/asm/setup.h
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> -#ifndef _UAPI__ALPHA_SETUP_H
> -#define _UAPI__ALPHA_SETUP_H
> -
> -#endif /* _UAPI__ALPHA_SETUP_H */

 You can't just remove a UAPI header like this, something will break; cf. 
arch/arc/include/uapi/asm/setup.h, or arch/x86/include/uapi/asm/setup.h if 
you want it brief.

 I suggest that you fold it into 01/26 (it makes no sense to have empty 
multiple inclusion protection), and likewise for the relevant remaining 
headers.

  Maciej

  reply	other threads:[~2023-05-16  0:53 UTC|newest]

Thread overview: 180+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 10:04 [PATCH v5 00/26] Remove COMMAND_LINE_SIZE from uapi Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 01/26] alpha: " Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 02/26] arm64: " Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 03/26] arm: " Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 04/26] ia64: " Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 05/26] m68k: " Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 06/26] microblaze: " Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 07/26] mips: " Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 08/26] parisc: " Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 09/26] powerpc: " Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 10/26] sparc: " Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 11/26] xtensa: " Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 12/26] riscv: " Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-07 21:41   ` Palmer Dabbelt
2023-03-07 21:41     ` Palmer Dabbelt
2023-03-07 21:41     ` Palmer Dabbelt
2023-03-07 21:41     ` Palmer Dabbelt
2023-03-07 21:41     ` Palmer Dabbelt
2023-03-07 21:41     ` Palmer Dabbelt
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 13/26] asm-generic: " Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 14/26] alpha: Remove empty <uapi/asm/setup.h> Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-05-16  0:53   ` Maciej W. Rozycki [this message]
2023-05-16  0:53     ` Maciej W. Rozycki
2023-05-16  0:53     ` Maciej W. Rozycki
2023-05-16  0:53     ` Maciej W. Rozycki
2023-05-16  0:53     ` Maciej W. Rozycki
2023-05-16  0:53     ` Maciej W. Rozycki
2023-03-06 10:04 ` [PATCH v5 15/26] arc: " Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 16/26] m68k: " Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:04 ` [PATCH v5 17/26] arm64: " Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04   ` Alexandre Ghiti
2023-03-06 10:04 ` Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 18/26] microblaze: " Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05 ` Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 19/26] sparc: " Alexandre Ghiti
2023-03-06 10:05 ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 20/26] parisc: " Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05 ` Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 21/26] x86: " Alexandre Ghiti
2023-03-06 10:05 ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 22/26] xtensa: " Alexandre Ghiti
2023-03-06 10:05 ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 23/26] powerpc: " Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05 ` Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 24/26] mips: " Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05 ` Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 25/26] s390: " Alexandre Ghiti
2023-03-06 10:05 ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05 ` [PATCH v5 26/26] riscv: " Alexandre Ghiti
2023-03-06 10:05 ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 10:05   ` Alexandre Ghiti
2023-03-06 13:19 ` [PATCH v5 00/26] Remove COMMAND_LINE_SIZE from uapi Philippe Mathieu-Daudé
2023-03-06 13:19 ` Philippe Mathieu-Daudé
2023-03-06 13:19   ` Philippe Mathieu-Daudé
2023-03-06 13:19   ` Philippe Mathieu-Daudé
2023-03-06 13:19   ` Philippe Mathieu-Daudé
2023-05-09  7:06 ` Alexandre Ghiti
2023-05-09  7:06 ` Alexandre Ghiti
2023-05-09  7:06   ` Alexandre Ghiti
2023-05-09  7:06   ` Alexandre Ghiti
2023-05-09  7:06   ` Alexandre Ghiti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2305160147100.11892@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=agordeev@linux.ibm.com \
    --cc=alexghiti@rivosinc.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=arnd@arndb.de \
    --cc=borntraeger@linux.ibm.com \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=chenhuacai@kernel.org \
    --cc=chris@zankel.net \
    --cc=christophe.leroy@csgroup.eu \
    --cc=corbet@lwn.net \
    --cc=dalias@libc.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=deller@gmx.de \
    --cc=geert@linux-m68k.org \
    --cc=gor@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hca@linux.ibm.com \
    --cc=hpa@zytor.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jcmvbkbc@gmail.com \
    --cc=kernel@xen0n.name \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=loongarch@lists.linux.dev \
    --cc=mattst88@gmail.com \
    --cc=mingo@redhat.com \
    --cc=monstr@monstr.eu \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=palmer@rivosinc.com \
    --cc=paul.walmsley@sifive.com \
    --cc=richard.henderson@linaro.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=svens@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=tsbogend@alpha.franken.de \
    --cc=vgupta@kernel.org \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.